soc: nuvoton: npcx: refactor npcx soc hierarchy for future chip support #87446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvsun
force-pushed
the
npcx_k3_extend
branch
2 times, most recently
from
b7854a3 to
e18f0ba
Compare
zephyrbot
requested review from
ChiHuaL,
fabiobaltieri,
jackrosenthal,
keith-zephyr,
MulinChao and
sjg20
nordicjm
requested changes
Mar 21, 2025
soc/nuvoton/npcx/Kconfig.soc
Outdated
Comment on lines
12
to
23
| config SOC_FAMILY_VARIANT_NPCXN | ||
| bool | ||
| select SOC_FAMILY_NPCX | ||
|
|
||
| config SOC_FAMILY_VARIANT_NPCKN | ||
| bool | ||
| select SOC_FAMILY_NPCX | ||
|
|
||
| config SOC_FAMILY_VARIANT | ||
| string | ||
| default "npcxn" if SOC_FAMILY_VARIANT_NPCXN | ||
| default "npckn" if SOC_FAMILY_VARIANT_NPCKN |
There was a problem hiding this comment.
do not add Kconfigs which use existing identifiers like SOC_FAMILY
| @@ -1,11 +1,14 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| zephyr_include_directories(.) | |||
| set(SOC_FAMILY_VARIANT ${CONFIG_SOC_FAMILY_VARIANT}) | |||
There was a problem hiding this comment.
this set isn't needed, use renamed variable directly
This commit refactors the NPCX SoC hierarchy to improve maintainability and enable future support for upcoming chips. Key changes include: 1. Introduced a new `npcxn` subdirectory under `common/` to consolidate shared components across the npcxn series. 2. Renamed and reorganized register access files for improved consistency. 3. Updated relevant Kconfig files, header files, and CMakeLists for the new structure. Signed-off-by: Alvis Sun <yfsun@nuvoton.com>
nordicjm
approved these changes
Apr 2, 2025
fabiobaltieri
approved these changes
Apr 4, 2025
ChiHuaL
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the NPCX SoC hierarchy to improve maintainability and enable future support for upcoming chips.
Key changes include:
npcxnsubdirectory undercommon/to consolidate shared components across the npcxn series.