drivers: i3c: add i3c v1.0 support #87448
Open
+130
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcpleung
previously approved these changes
Mar 21, 2025
XenuIsWatching
commented
Mar 22, 2025
drivers/i3c/i3c_common.c
Outdated
Comment on lines
789
to
800
| if (((target->flags & I3C_V1P0_SUPPORT) && (target->bcr & I3C_BCR_ADV_CAPABILITIES)) || | ||
| (!(target->flags & I3C_V1P0_SUPPORT))) { | ||
| /* | ||
| * GETCAPS (GETHDRCAP) is required to be supported for I3C v1.0 targets that support | ||
| * HDR modes and required if the Target's I3C version is v1.1 or later. | ||
| */ | ||
| ret = i3c_ccc_do_getcaps_fmt1(target, &caps); | ||
| if (ret != 0) { | ||
| return ret; | ||
| } |
There was a problem hiding this comment.
thinking more about this, i may need to add condition here as if an unknown v1.0 device is reported through DEFTGTS, it will get the info and then fail here, as it cannot know ahead of time if it is a v1.0 device
decsny
reviewed
Mar 22, 2025
Comment on lines
+71
to
+74
| v1p0-support: | ||
| type: boolean | ||
| description: | | ||
| Indicates if the device compiles to I3C v1.0. |
There was a problem hiding this comment.
why does this need to be a property in DT? isn't it already determinable by compat ?
There was a problem hiding this comment.
No, it is not. You'd have to read the datasheet of the part to see what spec version it compiles.
XenuIsWatching
force-pushed
the
i3c-v1.0
branch
from
b83dfca to
17748a2
Compare
This adds a v1.0 support dts flag for devices. This also makes it so it doesn't try to send a GETCAPS (GETHDRCAP) ccc if this flag is set and it doesn't support any HDR modes. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
XenuIsWatching
force-pushed
the
i3c-v1.0
branch
from
17748a2 to
b023155
Compare
In I3C v1.0, there was a RSTDAA direct CCC. It is deprecated in I3C v1.1 and later. This adds a CCC helper for it. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
This adds a shell helper for a direct rstdaa for I3C v1.0 devices Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
XenuIsWatching
force-pushed
the
i3c-v1.0
branch
from
b023155 to
402e928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I3C v1.0 does have few quirks with it. Such as supporting a direct RSTDAA as well as using GETHDRCAP.
This adds a devicetree flag to indicate support of v1.0. This resuses the same "bool" that support_setaasa used and turns it in to a flag byte.