drivers: i3c: add primary controller da property #87451
Open
+42
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a way to assign the dynamic address for a primary controller. This is the address that is broadcasted out with the ccc DEFTGTS, and is the address that secondary controllers use to communicate with the primary controller. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
XenuIsWatching
force-pushed
the
i3c-primary-controller-da
branch
from
7b0d0bd to
d290963
Compare
dcpleung
approved these changes
Mar 21, 2025
decsny
previously requested changes
Mar 21, 2025
Comment on lines
+34
to
+40
| primary-controller-da: | ||
| type: int | ||
| description: | | ||
| This is the self assigned dynamic address of the I3C controller. This | ||
| is the address is used to communicate with itself after a handoff by | ||
| a secondary controller. This is only used if the controller is a primary | ||
| controller. |
There was a problem hiding this comment.
I am not an i3c expert but this looks like maybe the property called assigned-address in linux https://www.kernel.org/doc/Documentation/devicetree/bindings/i3c/i3c.yaml
There was a problem hiding this comment.
I guess it looks like assigned-address is for the i3c devices, not bus controller, but does it not make sense to use the same property name since it seems to be used for a similar thing? or would that be confusing?
There was a problem hiding this comment.
Using the same name would be confusing imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to assign the dynamic address for a primary controller. This is the address that is broadcasted out with the ccc DEFTGTS, and is the address that secondary controllers use to communicate with the primary controller.