sys: cbprintf: logging: Fix opaque struct pointer warning #87461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use compiler trick to allow operations with all types of arguments. Previous solution was using arg+0 with suppressing compiler warning about pointer arithmetic operations but it was not covering for opaque struct pointers. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
|
@nordic-krch I added the "Fixes ..." reference to the PR description to point at my bug report, or will there still be some cases that are not covered by this solution? |
dcpleung
approved these changes
Mar 21, 2025
jhedberg
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use compiler trick to allow operations with all types of arguments. Previous solution was using arg+0 with suppressing compiler warning about pointer arithmetic operations but it was not covering for opaque struct pointers.
As suggested in #87310 it is possible to cover for opaque pointers in logging using the same approach.
Fixes #85775