Bluetooth: Classic: Move classic functions from conn.c to conn_br.c #87474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move functions `bt_sco_cleanup()`, `bt_conn_create_br()`, `bt_hci_connect_br_cancel()`, and `bt_conn_get_dst_br()` from `conn.c` to `conn_br.c`. Change the function `bt_hci_connect_br_cancel()` to internal public function. Add a header file `conn_br_internal.h`. And declare the function `bt_hci_connect_br_cancel()` in the header file. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
zephyrbot
added
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
cvinayak,
gzh-terry,
hermabe,
jhedberg,
makeshi,
MarkWangChinese,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
|
@lylezhu2012 why are you still leaving some BR/EDR functions in |
alwa-nordic
approved these changes
Mar 21, 2025
Too many functions use |
Ok, makes sense. Thanks for the clarification. |
jhedberg
approved these changes
Mar 24, 2025
MarkWangChinese
approved these changes
Mar 24, 2025
gzh-terry
reviewed
Mar 25, 2025
gzh-terry
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move functions
bt_sco_cleanup(),bt_conn_create_br(),bt_hci_connect_br_cancel(), andbt_conn_get_dst_br()fromconn.ctoconn_br.c.Change the function
bt_hci_connect_br_cancel()to internal public function.Add a header file
conn_br_internal.h. And declare the functionbt_hci_connect_br_cancel()in the header file.