drivers: stepper: Added fault event #87479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a fault event to stepper_event for stall unrelated problems. Signed-off-by: Jan Behrens <jan.behrens@navimatix.de>
zephyrbot
requested review from
bjarki-andreasen,
dipakgmx,
fabiobaltieri and
faxe1008
faxe1008
approved these changes
Mar 21, 2025
jilaypandya
approved these changes
Mar 21, 2025
| @@ -95,6 +95,8 @@ enum stepper_event { | |||
| STEPPER_EVENT_RIGHT_END_STOP_DETECTED = 3, | |||
| /** Stepper has stopped */ | |||
| STEPPER_EVENT_STOPPED = 4, | |||
| /** Fault with the stepper controller detected */ | |||
There was a problem hiding this comment.
Nit
Suggested change
| /** Fault with the stepper controller detected */ | |
| /** Fault detected with the stepper controller */ |
There was a problem hiding this comment.
@jbehrensnx would you also be implementing this interrupt based fault detection for ti drv8424 driver?
There was a problem hiding this comment.
That's the plan, but as there will be some other changes to the drv8424 driver, it will definitely be a separate PR.
dipakgmx
approved these changes
Mar 22, 2025
bjarki-andreasen
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stepper api currently lacks an event for issues unrelated to motor stalls, e.g. power supply issues or thermal shutdown. This PR adds a corresponding fault event.