drivers: reset: Add generic reset MMIO driver #87501
Conversation
|
|
||
| description: MMIO Reset | ||
|
|
||
| compatible: "zephyr,reset-mmio" |
There was a problem hiding this comment.
This isn't Zephyr-specific?
There was a problem hiding this comment.
Yes, but I wasn't sure how to give this a generic name in zephyr, do you have a suggestion?
There was a problem hiding this comment.
If @henrikbrixandersen doesn't have a better idea, I don't either
| required: true | ||
| num_resets: | ||
| type: int | ||
| default: 1 |
There was a problem hiding this comment.
Defaults need to be described in the textual description.
There was a problem hiding this comment.
This is not resolved. The description needs to say why the value chosen, and not just restate the value. Please read https://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#rules-for-default-values and update this PR accordingly. (Hint: if you can't come up with a justification that follows the rules, consider making this required instead.)
There was a problem hiding this comment.
Done, I don't have a good justification for setting the default to 1 so changed this to a required property.
saimohith-google
force-pushed
the
main
branch
2 times, most recently
from
bb7af4c to
850cc9e
Compare
drivers/reset/Kconfig.mmio
Outdated
|
|
||
| config RESET_MMIO | ||
| bool "Generic MMIO reset driver" | ||
| default n |
There was a problem hiding this comment.
This should be default y + depends on DT_HAS_your_compatible_goes_here_ENABLED. Search the tree for other drivers for examples.
| required: true | ||
| num_resets: | ||
| type: int | ||
| default: 1 |
There was a problem hiding this comment.
This is not resolved. The description needs to say why the value chosen, and not just restate the value. Please read https://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#rules-for-default-values and update this PR accordingly. (Hint: if you can't come up with a justification that follows the rules, consider making this required instead.)
| @@ -0,0 +1,10 @@ | |||
| # Copyright (c) 2025 Google LLC | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
| set(BOARD qemu_x86) | |||
There was a problem hiding this comment.
Don't hard-code the board here. This prevents people from testing this on other platforms that might actually have real hardware.
Follow the platform_allow / integration_platforms pattern in tests/drivers/gpio/gpio_reserved_ranges/testcase.yaml instead. See the twister documentation for more details if you need them.
| description: Number of resets controlled by the register. Can be in the | ||
| range [1, 31]. |
There was a problem hiding this comment.
This style isn't permitted upstream -- see https://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#descriptions and please fix
|
|
||
| description: MMIO Reset | ||
|
|
||
| compatible: "zephyr,reset-mmio" |
There was a problem hiding this comment.
If @henrikbrixandersen doesn't have a better idea, I don't either
| properties: | ||
| reg: | ||
| required: true | ||
| num_resets: |
There was a problem hiding this comment.
| required: true | ||
| description: Number of resets controlled by the register. Can be in the | ||
| range [1, 31]. | ||
| active_low: |
Introduce a generic reset MMIO driver to be used for devices with a single memory mapped reset bit required to take them out of reset. Signed-off-by: Mohith Potluri <saimohith@google.com>
Introduce a generic reset MMIO driver to be used for devices with a single memory mapped reset bit required to take them out of reset.