drivers: udc_rpi_pico: replace message queue with k_events and minor fixes #87506
+255
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set suspended state on suspend/resume ISR. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
jfischer-no
added
area: Drivers
area: USB
tmon-nordic
previously approved these changes
Mar 24, 2025
Using k_events eliminates the drawback of the queue potentially dropping messages and provides a reliable event notification mechanism. It is similar to commit c2f2d8c ("drivers: usb: udc_dwc2: Replace queue with events") Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
Support VBUS state change detection and enable/disable DP pull-up according to VBUS state when pinctrl property is provided. It brings the similar functionality introduced in commit 4c0317f ("drivers: usb_dc_rpi_pico: Implemented vbus detection handling") for the legacy device controller driver. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
Mark endpoint as not busy after transfer is canceled. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
For the IN endpoint, we only need to set/reset the STALL bit in the endpoint control register. To set halt on the OUT endpoint, the AVAILABLE bit must also be set, which is similar to starting a new transfer, but first any transfer in progress must be canceled. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
Do not check if the tailroom is greater than or equal to MPS because the controller does not write directly to the buffer and therefore cannot write outside the buffer. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
At high throughput, the controller sometimes fails to start a new transaction. Clearing the corresponding endpoint bit in the BUFF_STATUS completion register before initiating a new transaction solves this problem. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
Fix USB controller base address. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
jfischer-no
force-pushed
the
pr-udc-rp_pico-rework
branch
from
ecbca9d to
1f02e60
Compare
github-actions
bot
added
the
platform: Raspberry Pi Pico
ajf58
approved these changes
Mar 28, 2025
|
|
||
| k_msgq_get(&drv_msgq, &evt, K_FOREVER); | ||
| ep_cfg = udc_get_ep_cfg(dev, evt.ep); | ||
| evt = k_event_wait(&priv->events, UINT32_MAX, false, K_FOREVER); |
There was a problem hiding this comment.
Should this be either:
- The bitmask of all the defined events (e.g.
(RPI_PICO_EVT_XFER_FINISHED << 1) - 1)or similar. Or: - Should there be some checking (maybe an assert) that at the bottom of this function all events bits have been handled?
Inspection of the code says "yes, everything defined in the enum is covered below", but it feels like it'd be possible to get out of sync here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace message queue with k_events, support VBUS state change detection, fix clear/set endpoint halt.