-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: serial/sensor: kconfig: Fix unsorted additions #87549
Conversation
nordicjm
commented
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the sensor Kconfig mostly unreadable
It was done this way to easily find the vendor top level Kconfig vs the individual sensor Kconfigs that remained after adding the vendor directories. I'd be ok if these were two sorted blocks but kept separate.
Fixes Kconfig files that have not been added in the right place Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds sort to individual sensor Kconfigs and sorts them Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
84fbe77
to
fcd564a
Compare
Did not notice that, have left as 2 sorted lists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Maybe add a comment at the beginning of each block so there's no ambiguity? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!