Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: serial/sensor: kconfig: Fix unsorted additions #87549

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

nordicjm
Copy link
Collaborator

Fixes Kconfig files that have not been added in the right place

tejlmand
tejlmand previously approved these changes Mar 24, 2025
Copy link
Collaborator

@teburd teburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the sensor Kconfig mostly unreadable

It was done this way to easily find the vendor top level Kconfig vs the individual sensor Kconfigs that remained after adding the vendor directories. I'd be ok if these were two sorted blocks but kept separate.

Fixes Kconfig files that have not been added in the right place

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds sort to individual sensor Kconfigs and sorts them

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
@nordicjm
Copy link
Collaborator Author

This makes the sensor Kconfig mostly unreadable

It was done this way to easily find the vendor top level Kconfig vs the individual sensor Kconfigs that remained after adding the vendor directories. I'd be ok if these were two sorted blocks but kept separate.

Did not notice that, have left as 2 sorted lists

@nordicjm nordicjm requested review from teburd and tejlmand March 24, 2025 13:40
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fabiobaltieri
Copy link
Member

Did not notice that, have left as 2 sorted lists

Maybe add a comment at the beginning of each block so there's no ambiguity?

Copy link
Collaborator

@teburd teburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kartben kartben merged commit 5c027f2 into zephyrproject-rtos:main Mar 26, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sensors Sensors area: UART Universal Asynchronous Receiver-Transmitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.