drivers: wifi: siwx91x: Add AP configuration enhancements and hidden SSID support #87570

ArunmaniAlagarsamy2710 · 2025-03-24T14:28:34Z

This PR introduces enhancements to the siwx91x Wi-Fi driver, including support for configuring AP settings, hidden SSID functionality, and validation checks for interface state.

drivers/wifi/siwx91x/siwx91x_wifi.c

ArunmaniAlagarsamy2710 · 2025-04-04T06:53:54Z

Rebased to resolve the conflicts

jerome-pouiller

Just a couple of questions. Otherwise, it looks fine.

jerome-pouiller · 2025-04-07T15:41:45Z

drivers/wifi/siwx91x/siwx91x_wifi.c

 		return -ENOTSUP;
 	}

+	/*FIXME siwx91x_ap_cfg.channel.channel = SL_WIFI_BAND_2_4GHZ */


I don't understand this FIXME. SL_WIFI_BAND_2_4GHZ does not make sense for siwx91x_ap_cfg.channel.channel. Do you mean siwx91x_ap_cfg.channel.band ?

jerome-pouiller · 2025-04-07T15:43:52Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+	}
+
+	if (sidev->state == WIFI_STATE_COMPLETED) {
+		return 0;


Do you know what the API expect if ap_enable() is called twice with different parameters?

Removed this change for now. We'll raise a separate PR to handle ap_enable with different parameters

jerome-pouiller · 2025-04-07T15:44:36Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+
+	siwx91x_ap_cfg.channel.bandwidth = SL_WIFI_BANDWIDTH_20MHz;
+
+	if ((params->ssid_length == 0) || (params->ssid_length > WIFI_SSID_MAX_LEN)) {


Parentheses are useless in this expression.

jerome-pouiller · 2025-04-07T15:46:07Z

drivers/wifi/siwx91x/siwx91x_wifi.c

 	int ret;

+	if (sidev->state == WIFI_STATE_COMPLETED) {
+		return 0;


Do you know what the API expect if connect() is called twice with different parameters?

Removed this change for now. We'll raise a separate PR to handle connect() with different parameters

jerome-pouiller · 2025-04-07T16:28:04Z

soc/silabs/silabs_siwx91x/siwg917/nwp.h

+	uint8_t oper_mode;
+	bool hidden_ssid;
+	uint8_t max_num_sta;
+} siwx91x_boot_config_feature_t;


Unless you plan to add more parameters, I am not sure we need to introduce this struct. You can pass the 3 parameters to siwx91x_nwp_mode_switch().

jerome-pouiller · 2025-04-09T11:58:32Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+		return -ENOTSUP;
+	}
+
+	siwx91x_ap_cfg.channel.bandwidth = SL_WIFI_BANDWIDTH_20MHz;


Why this field is not set during the structure initialisation as the other ones?

jerome-pouiller · 2025-04-09T12:01:17Z

drivers/wifi/siwx91x/siwx91x_wifi.c

@@ -303,7 +314,8 @@ static int siwx91x_connect(const struct device *dev, struct wifi_connect_req_par
 	wifi_config.ssid.length = params->ssid_length,
 	memcpy(wifi_config.ssid.value, params->ssid, params->ssid_length);

-	ret = sl_wifi_connect(SL_WIFI_CLIENT_INTERFACE, &wifi_config, 0);
+	interface = sl_wifi_get_default_interface();


Sometime interface is initialized declaration, sometime later in the code. Is it possible to uniformize that?

jerome-pouiller · 2025-04-09T12:12:06Z

soc/silabs/silabs_siwx91x/siwg917/nwp.c

-		return -EINVAL;
+	status = siwx91x_get_nwp_config(oper_mode, hidden_ssid, max_num_sta, &nwp_config);
+	if (status < 0) {
+		return status;


Can you create a specific commit for the change SL_SI91X_CLIENT_MODE/SL_SI91X_ACCESS_POINT_MODE -> WIFI_STA_MODE/WIFI_AP_MODE.

jerome-pouiller · 2025-04-09T12:15:54Z

soc/silabs/silabs_siwx91x/siwg917/nwp.c

+		if (max_num_sta > AP_MAX_NUM_STA) {
+			LOG_ERR("Exceeded maximum supported stations (%d)", AP_MAX_NUM_STA);
+			return -EINVAL;
+		}


Group the short paths at the start of the function:

if (wifi_oper_mode == WIFI_AP_MODE && max_num_sta > AP_MAX_NUM_STA) return -EINVAL;

jerome-pouiller · 2025-04-09T12:18:33Z

soc/silabs/silabs_siwx91x/siwg917/nwp.c

 LOG_MODULE_REGISTER(siwx91x_nwp);

-int siwg91x_get_nwp_config(int wifi_oper_mode, sl_wifi_device_configuration_t *get_config)
+int siwx91x_get_nwp_config(uint8_t wifi_oper_mode, bool hidden_ssid, uint8_t max_num_sta,
+			   sl_wifi_device_configuration_t *get_config)


Usually, the returned arguments are placed first in the list of arguments. Rationale, it mimics the usual code:

memcpy(destination, source, ..); destination = source;

jerome-pouiller · 2025-04-09T12:22:38Z

drivers/wifi/siwx91x/siwx91x_wifi.c

+		}
+
+		break;
+	}


What is the purpose of a such design? why do you want to introduce a level of indirection rather than declaring two functions?

This patch introduces validation checks to ensure Wi-Fi commands are executed only when the device is in a valid operational mode. - Restricts command execution if the device is not in an appropriate mode - Prevents reconfiguring the device when it is already in an active state Signed-off-by: Arunmani Alagarsamy <arunmani.a@silabs.com>

Replaced SL_SI91X_CLIENT_MODE and SL_SI91X_ACCESS_POINT_MODE with WIFI_STA_MODE and WIFI_AP_MODE, respectively, for AP configuration command intergration. Signed-off-by: Arunmani Alagarsamy <arunmani.a@silabs.com>

This patch adds support for configuring AP. It enables setting key parameters before AP mode is enabled. - Adds support for configuring client maximum inactivity timeout. - Adds support for bandwidth, It supports 20MHZ only. - Adds support for setting the maximum number of clients and hidden SSID mode by rebooting the NWP device. Signed-off-by: Arunmani Alagarsamy <arunmani.a@silabs.com>

ArunmaniAlagarsamy2710 · 2025-04-10T13:17:47Z

Rebased to resolve conflicts

ArunmaniAlagarsamy2710 force-pushed the add/ap_config branch 3 times, most recently from b8fcd2e to caac617 Compare March 25, 2025 14:16

ArunmaniAlagarsamy2710 changed the title ~~drivers: wifi: siwx91x: Add support for AP settings~~ drivers: wifi: siwx91x: Add AP configuration enhancements and hidden SSID support Mar 25, 2025

ArunmaniAlagarsamy2710 force-pushed the add/ap_config branch from caac617 to b274b59 Compare March 26, 2025 08:45

NiteshKShah reviewed Mar 26, 2025

View reviewed changes

drivers/wifi/siwx91x/siwx91x_wifi.c Outdated Show resolved Hide resolved

NiteshKShah reviewed Mar 26, 2025

View reviewed changes

drivers/wifi/siwx91x/siwx91x_wifi.c Outdated Show resolved Hide resolved

NiteshKShah reviewed Mar 26, 2025

View reviewed changes

drivers/wifi/siwx91x/siwx91x_wifi.c Outdated Show resolved Hide resolved

NiteshKShah reviewed Mar 26, 2025

View reviewed changes

drivers/wifi/siwx91x/siwx91x_wifi.c Outdated Show resolved Hide resolved

ArunmaniAlagarsamy2710 force-pushed the add/ap_config branch from b274b59 to c3646d9 Compare March 27, 2025 12:27

ArunmaniAlagarsamy2710 force-pushed the add/ap_config branch 2 times, most recently from 7963dd4 to 9b0fa49 Compare April 4, 2025 06:53

ArunmaniAlagarsamy2710 force-pushed the add/ap_config branch 2 times, most recently from b2a1d9c to a7f14ec Compare April 7, 2025 09:42

ArunmaniAlagarsamy2710 marked this pull request as ready for review April 7, 2025 09:42

github-actions bot added platform: Silabs Silicon Labs area: Wi-Fi Wi-Fi labels Apr 7, 2025

github-actions bot requested review from asmellby, jerome-pouiller, jhedberg, jukkar, Kludentwo, krish2718, MaochenWang1, Martinhoff-maker and rlubos April 7, 2025 09:43

github-actions bot assigned jhedberg and asmellby Apr 7, 2025

jerome-pouiller reviewed Apr 7, 2025

View reviewed changes

ArunmaniAlagarsamy2710 force-pushed the add/ap_config branch from a7f14ec to 9397c68 Compare April 9, 2025 09:16

ArunmaniAlagarsamy2710 requested a review from jerome-pouiller April 9, 2025 09:22

jerome-pouiller requested changes Apr 9, 2025

View reviewed changes

ArunmaniAlagarsamy2710 force-pushed the add/ap_config branch from 9397c68 to fad3728 Compare April 10, 2025 13:07

ArunmaniAlagarsamy2710 added 3 commits April 10, 2025 18:41

drivers: wifi: siwx91x: Replace opermode flags

75ac941

Replaced SL_SI91X_CLIENT_MODE and SL_SI91X_ACCESS_POINT_MODE with WIFI_STA_MODE and WIFI_AP_MODE, respectively, for AP configuration command intergration. Signed-off-by: Arunmani Alagarsamy <arunmani.a@silabs.com>

ArunmaniAlagarsamy2710 force-pushed the add/ap_config branch from fad3728 to 15f9f36 Compare April 10, 2025 13:17

ArunmaniAlagarsamy2710 requested a review from jerome-pouiller April 10, 2025 13:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers: wifi: siwx91x: Add AP configuration enhancements and hidden SSID support #87570

drivers: wifi: siwx91x: Add AP configuration enhancements and hidden SSID support #87570

ArunmaniAlagarsamy2710 commented Mar 24, 2025 •

edited

Loading

ArunmaniAlagarsamy2710 commented Apr 4, 2025

jerome-pouiller left a comment

jerome-pouiller Apr 7, 2025

jerome-pouiller Apr 7, 2025

ArunmaniAlagarsamy2710 Apr 9, 2025 •

edited

Loading

jerome-pouiller Apr 7, 2025

jerome-pouiller Apr 7, 2025

ArunmaniAlagarsamy2710 Apr 9, 2025 •

edited

Loading

jerome-pouiller Apr 7, 2025

jerome-pouiller Apr 9, 2025

jerome-pouiller Apr 9, 2025

jerome-pouiller Apr 9, 2025

jerome-pouiller Apr 9, 2025

jerome-pouiller Apr 9, 2025

jerome-pouiller Apr 9, 2025

ArunmaniAlagarsamy2710 commented Apr 10, 2025


		siwx91x_ap_cfg.channel.bandwidth = SL_WIFI_BANDWIDTH_20MHz;

		if ((params->ssid_length == 0) \|\| (params->ssid_length > WIFI_SSID_MAX_LEN)) {

+              		}
+              		break;
+              	}

drivers: wifi: siwx91x: Add AP configuration enhancements and hidden SSID support #87570

Are you sure you want to change the base?

drivers: wifi: siwx91x: Add AP configuration enhancements and hidden SSID support #87570

Conversation

ArunmaniAlagarsamy2710 commented Mar 24, 2025 • edited Loading

ArunmaniAlagarsamy2710 commented Apr 4, 2025

jerome-pouiller left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArunmaniAlagarsamy2710 Apr 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArunmaniAlagarsamy2710 Apr 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArunmaniAlagarsamy2710 commented Apr 10, 2025

ArunmaniAlagarsamy2710 commented Mar 24, 2025 •

edited

Loading

ArunmaniAlagarsamy2710 Apr 9, 2025 •

edited

Loading

ArunmaniAlagarsamy2710 Apr 9, 2025 •

edited

Loading