Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsys: sd: correct mismatched comment for CONFIG_SDMMC_STACK #87598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

subsys: sd: correct mismatched comment for CONFIG_SDMMC_STACK #87598

wants to merge 1 commit into from
+1 −1

Conversation

mshinjo
Copy link
Contributor

@mshinjo mshinjo commented Mar 24, 2025

The closing comment for CONFIG_SDMMC_STACK #ifdef directive was incorrectly labeled as CONFIG_SDIO_STACK. This commit corrects the comment to reflect the correct configuration macro and improve code clarity.

@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: Disk Access labels Mar 24, 2025
@mshinjo
Copy link
Contributor Author

mshinjo commented Mar 24, 2025

Hello maintainers,
I was wondering if PRs that fix minor, cosmetic issues—those that have no effect on the program’s behavior, such as this PR—are appreciated or welcomed in the Zephyr Project. In other words, are these types of PRs considered to add extra work for maintainers, or do they contribute positively?

@mshinjo
sd: correct mismatched comment for CONFIG_SDMMC_STACK
e8f5755 
The closing comment for CONFIG_SDMMC_STACK #ifdef directive was
incorrectly labeled as CONFIG_SDIO_STACK. This commit corrects the
comment to reflect the correct configuration macro and improve code
clarity.

Signed-off-by: Mirai SHINJO <oss@mshinjo.com>
@mshinjo mshinjo force-pushed the fix-mismatched-endif-comment-in-sd branch from cae6470 to e8f5755 Compare March 24, 2025 23:39
@kartben
Copy link
Collaborator

kartben commented Mar 25, 2025

Hello maintainers,
I was wondering if PRs that fix minor, cosmetic issues—those that have no effect on the program’s behavior, such as this PR—are appreciated or welcomed in the Zephyr Project. In other words, are these types of PRs considered to add extra work for maintainers, or do they contribute positively?

They are much appreciated :) Thanks for taking the time!

@kartben kartben added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Mar 25, 2025
@mshinjo
Copy link
Contributor Author

mshinjo commented Mar 25, 2025

Hello maintainers,
I was wondering if PRs that fix minor, cosmetic issues—those that have no effect on the program’s behavior, such as this PR—are appreciated or welcomed in the Zephyr Project. In other words, are these types of PRs considered to add extra work for maintainers, or do they contribute positively?

They are much appreciated :) Thanks for taking the time!

Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@jfischer-no jfischer-no jfischer-no approved these changes

@decsny decsny decsny approved these changes

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

Assignees

@danieldegrasse danieldegrasse

Labels
area: Disk Access size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mshinjo @kartben @jfischer-no @decsny @zephyrbot @danieldegrasse