Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: add new maintainers for Nuvoton NPCX platforms #87622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChiHuaL
Copy link
Contributor

@ChiHuaL ChiHuaL commented Mar 25, 2025

Add Nuvoton guys, TomChang19 and Alvsun, in maintainers of Nuvoton NPCX platforms and remove them from collaborators.

Add Nuvoton guys, TomChang19 and Alvsun, in maintainers of Nuvoton NPCX
platforms and remove them from collaborators.

Signed-off-by: Jun Lin <CHLin56@nuvoton.com>
@ChiHuaL ChiHuaL marked this pull request as ready for review March 26, 2025 01:56
@github-actions github-actions bot added size: XS A PR changing only a single line of code area: Process labels Mar 26, 2025
@kartben
Copy link
Collaborator

kartben commented Mar 27, 2025

@ChiHuaL can you elaborate on why you need this many - 4 maintainers seems like a lot :) Maybe there is a way to split in multiple areas?

@ChiHuaL ChiHuaL closed this Mar 28, 2025
@ChiHuaL ChiHuaL reopened this Mar 28, 2025
@ChiHuaL
Copy link
Contributor Author

ChiHuaL commented Mar 28, 2025

@ChiHuaL can you elaborate on why you need this many - 4 maintainers seems like a lot :) Maybe there is a way to split in multiple areas?

We found TomChang19 and Alvsun cannot add the backport tag for PRs made by Nuvoton. (The gear icon does not show in their web UI with their account.)
We believe the reason should be they are the collaborators but the maintainers.
That's the motivation we like them in the maintainer list.

@kartben
Copy link
Collaborator

kartben commented Mar 28, 2025

@ChiHuaL can you elaborate on why you need this many - 4 maintainers seems like a lot :) Maybe there is a way to split in multiple areas?

We found TomChang19 and Alvsun cannot add the backport tag for PRs made by Nuvoton. (The gear icon does not show in their web UI with their account.) We believe the reason should be they are the collaborators but the maintainers. That's the motivation we like them in the maintainer list.

No, the reason is that they should be added as contributors to the zephyr-rtos GitHub organization. This was probably an oversight when they got added to the MAINTAINERS file and no one checked they were contributors already (or they never accepted the invite from GitHub)
Please apply here: https://github.com/zephyrproject-rtos/zephyr/issues/new?assignees=&labels=Role+Nomination&projects=&template=006_nomination.md&title=

@TomChang19 @alvsun

@kartben
Copy link
Collaborator

kartben commented Mar 29, 2025

Please consider closing the PR if my comment above addresses your original intent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Process size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants