Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: fix support for U-Blox M10 modules with M8 driver #87627

Merged
merged 1 commit into from
Mar 26, 2025
Merged

drivers: fix support for U-Blox M10 modules with M8 driver #87627

merged 1 commit into from
Mar 26, 2025

Conversation

XDjackieXD
Copy link

Fixes the issue described here: #87444

@XDjackieXD XDjackieXD mentioned this pull request Mar 25, 2025
Closed
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: GNSS labels Mar 25, 2025
@github-actions GitHub Actions
Copy link

Hello @XDjackieXD, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

drivers: fix support for U-Blox M10 modules with M8 driver
29752f8 
The U-Blox M10 seems to interleave UBX and NMEA messages in a way that
confuses the M8 driver leading to missing the same message that directly
follows the UBX part every time (leading to no navigation updates).
As the driver does not parse the UBX blocks during normal operation anyways
it can just be disabled.

Signed-off-by: Jakob Riepler <jakob+zephyr@chaosfield.at>
@fabiobaltieri fabiobaltieri added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Mar 25, 2025
bjarki-andreasen
bjarki-andreasen approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@tomi-font tomi-font linked an issue Mar 25, 2025 that may be closed by this pull request
U-Blox M10 UBX/NMEA mix issues with M8 driver #87444
Closed
@kartben kartben merged commit 7512eb0 into zephyrproject-rtos:main Mar 26, 2025
27 checks passed
@github-actions GitHub Actions
Copy link

Hi @XDjackieXD!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@bjarki-andreasen bjarki-andreasen bjarki-andreasen approved these changes

@tomi-font tomi-font tomi-font approved these changes

Assignees

@bjarki-andreasen bjarki-andreasen

Labels
area: GNSS size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

U-Blox M10 UBX/NMEA mix issues with M8 driver
6 participants
@XDjackieXD @fabiobaltieri @bjarki-andreasen @tomi-font @kartben @zephyrbot