drivers: ethernet: phy: mii: simplify if all are fixed link #87628
Conversation
add DT_ALL_INST_HAS_BOOL_STATUS_OKAY() macro. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
add test for DT_ALL_INST_HAS_BOOL_STATUS_OKAY() macro. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
add DT_ANY_INST_HAS_PROP_STATUS_OKAY() macro. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
maass-hamburg
force-pushed
the
phy_mii_fixed_link
branch
2 times, most recently
from
69ee255 to
ec38b16
Compare
add test for DT_ALL_INST_HAS_PROP_STATUS_OKAY() macro. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
maass-hamburg
force-pushed
the
phy_mii_fixed_link
branch
from
ec38b16 to
a4d3f76
Compare
github-actions
bot
requested review from
decsny,
galak,
lmajewski,
pdgendt and
rruuaanng
maass-hamburg
force-pushed
the
phy_mii_fixed_link
branch
from
a4d3f76 to
a5cc188
Compare
| * @return Macro evaluates to `1,` if instance has the property, | ||
| * otherwise it evaluates to literal nothing. | ||
| */ | ||
| #define DT_ALL_INST_HAS_PROP_STATUS_OKAY__(idx, prop) \ |
There was a problem hiding this comment.
Sorry. This name is truly bizarre, why add an underscore at the end?
Edit
I think we should start with the name itself, otherwise, we can't define its fundamental behavior. At least at first glance, the underscore seems to exist solely to avoid duplicate naming.
There was a problem hiding this comment.
I just added these similar to the already existing DT_ANY_INST_HAS**. These just use a kind af a reversed logic.
There was a problem hiding this comment.
I agree with @rruuaanng ; these names need to be revisited
There was a problem hiding this comment.
IF that name should be changed, we should also do that with the already merged DT_ANY_INST_HAS_PROP_STATUS_OKAY and DT_ANY_INST_HAS_BOOL_STATUS_OKAY.
Do you have a suggestion for the change or do we want to to the change in a later PR?
| * | ||
| * @return Evaluates to list of 1s (e.g: 1,1,1,) or nothing. | ||
| */ | ||
| #define DT_ALL_INST_HAS_PROP_STATUS_OKAY_(prop) \ |
| * @return Macro evaluates to `1,` if instance property value is 0, | ||
| * otherwise it evaluates to literal nothing. | ||
| */ | ||
| #define DT_ALL_INST_HAS_BOOL_STATUS_OKAY__(idx, prop) \ |
| * | ||
| * @return Evaluates to list of 1s (e.g: 1,1,1,) or nothing. | ||
| */ | ||
| #define DT_ALL_INST_HAS_BOOL_STATUS_OKAY_(prop) \ |
maass-hamburg
force-pushed
the
phy_mii_fixed_link
branch
from
a5cc188 to
f67d53f
Compare
If all instances are fixed link, remove code that is not needed for that. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
maass-hamburg
force-pushed
the
phy_mii_fixed_link
branch
from
f67d53f to
56f755d
Compare
| * DT_ALL_INST_HAS_PROP_STATUS_OKAY(baz) // 0 | ||
| * @endcode | ||
| */ | ||
| #define DT_ALL_INST_HAS_PROP_STATUS_OKAY(prop) \ |
There was a problem hiding this comment.
actually maybe this would be better named as DT_ALL_INST_STATUS_OKAY_HAS_PROP
There was a problem hiding this comment.
I also like that a bit better, but there is already a DT_ANY_INST_HAS_PROP_STATUS_OKAY with any instead of all, that is already in main and the last release, so I prefer to have it consistent.
If all instances are fixed link, remove code that is
not needed for that.