-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable SDHC support on imx93 Cortex-A Core platform #87635
base: main
Are you sure you want to change the base?
enable SDHC support on imx93 Cortex-A Core platform #87635
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
boards/nxp/imx93_evk/doc/index.rst
Outdated
@@ -108,6 +110,23 @@ Serial Port | |||
This board configuration uses a single serial communication channel with the | |||
CPU's UART2 for A55 core and M33 core. | |||
|
|||
uSDHC (SD or eMMC Interface) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this can't be enabled on the board by default (is this USDHC interface shared with Linux/Uboot?)- can we add some form of testcase definition in tests/subsys/sd/sdmmc
to validate that the subsystem works on this board?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @danieldegrasse, good catch, currently we rely on uboot or linux to start A-core zephyr, so Zephyr can't use the same uSDHC controller with uboot or Linux, that is to say:
- if board is booted from SD Card (which uses uSDHC2), so we only could use uSDHC1 for Zephyr
tests/subsys/sd/mmc
testing. - if board is booted from mmc (which uses uSDHC1), so we only could use uSDHC2 for Zephyr
tests/subsys/sd/sdmmc
testing
I will update this document and provides overlay for both uSDHC controllers to address this issues, thanks.
b4b7fd1
to
3c3f288
Compare
V2: Addressed @danieldegrasse's comments, added two overlay for each uSDHC controller, and updated document to address need to avoid conflict with U-Boot and Linux. |
Format the driver by using clang-format. Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
There is no soc.h for some platform, so only include it when it is available. Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
Enable MMIO mapping in the driver. Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
Add device nodes for SDHC. Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
Tmp patch for dependency on hal_nxp PR 524. Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
af1d47f
to
0244d33
Compare
Added pinctrl and dts nodes for uSDHC1 and uSDHC2, they are disabled by default, and provided overlay file to enable uSDHC2 if needed. Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com> Signed-off-by: Lei Xu <lei.xu@nxp.com>
0244d33
to
71b4461
Compare
Hi, @danieldegrasse , would you please review this PR again? thanks. |
Depend on zephyrproject-rtos/hal_nxp#524