drivers: udc_ambiq: fix compilation issue after dwc2 header removal #87664
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessandroLuo
previously approved these changes
Mar 26, 2025
aaronyegx
previously approved these changes
Mar 27, 2025
jfischer-no
requested changes
Mar 27, 2025
drivers/usb/udc/udc_ambiq.c
Outdated
Comment on lines
51
to
54
| #define USB_TEST_MODE_FEAT_SEL_TESTJ 1UL | ||
| #define USB_TEST_MODE_FEAT_SEL_TESTK 2UL | ||
| #define USB_TEST_MODE_FEAT_SEL_TESTSN 3UL | ||
| #define USB_TEST_MODE_FEAT_SEL_TESTPM 4UL |
There was a problem hiding this comment.
These may be useful to others, and driver definitions should be prefixed differently. Please cherry-pick jfischer-no@2624e0e or apply https://github.com/jfischer-no/zephyr/commit/2624e0e6e1e55c81a4afd83d92e3afa8e9afa063.patch
There was a problem hiding this comment.
Hi @jfischer-no, thanks, that's much better to put them into common header since these are the definitions inside USB specification. Change done and pushed. Please help to have a look again.
udc_ambiq was using USB test mode definition in dwc2 header, which the include was removed, hence compilation now fails. This commit fixes the compilation failure. Signed-off-by: Chew Zeh Yang <zeon.chew@ambiq.com>
zeonchew
force-pushed
the
pr-udc-ambiq-fix-compile-err
branch
from
2be9a29 to
2992ce2
Compare
jfischer-no
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
udc_ambiq was using USB test mode definition in dwc2 header, which the include was removed, hence compilation now fails.
This PR is to fix the compilation error for udc_ambiq.c