drivers: usb host: Add the USB host virtual serial port architecture …

[kevinwang827]

…developed by Quectel to subsys

1. Complete the entire process of USB host enumeration
2. Complete the communication of the virtual serial port
3. Currently adapted to the USB HOST of the STM32 series

Signed-off-by: kevin.wang Developer kevin.wang@quectel.com

new file:   dts/bindings/usb/quectel,userial.yaml
new file:   include/zephyr/userial/quectel/quec_uhc_app.h
new file:   samples/subsys/usb/userial/quectel/CMakeLists.txt
new file:   samples/subsys/usb/userial/quectel/README.rst
new file:   samples/subsys/usb/userial/quectel/app.overlay
new file:   samples/subsys/usb/userial/quectel/main.c
new file:   samples/subsys/usb/userial/quectel/prj.conf
new file:   samples/subsys/usb/userial/quectel/sample.yaml
modified:   subsys/Kconfig
modified:   subsys/usb/CMakeLists.txt
new file:   subsys/usb/userial/quectel/CMakeLists.txt
new file:   subsys/usb/userial/quectel/Kconfig
new file:   subsys/usb/userial/quectel/driver/Kconfig.stm32
new file:   subsys/usb/userial/quectel/driver/quec_ringbuffer.c
new file:   subsys/usb/userial/quectel/driver/quec_ringbuffer.h
new file:   subsys/usb/userial/quectel/driver/quec_uhc_driver.h
new file:   subsys/usb/userial/quectel/driver/quec_uhc_driver_stm32.c
new file:   subsys/usb/userial/quectel/driver/quec_uhc_enumeration.c
new file:   subsys/usb/userial/quectel/driver/quec_uhc_memory.c
new file:   subsys/usb/userial/quectel/quec_uhc_userial.c

[jfischer-no]

Thanks, but no. I suggest you start with https://docs.zephyrproject.org/latest/index.html. Then please look at the code and the commit messages. Try to understand how the project is built, and try to make some small contributions. What will definitely not be successful is to just take some existing code and try to throw it into the project, this is not a trash can.

[kartben]

@jfischer-no There is nothing in this PR that call for this kind of rude language. It is clear to me that @kevinwang827 has done some homework before sending the pull request, and I'm sorry but saying that it's just throwing code into the project as if it was a trash can is simply not acceptable.

Can you please provide a couple bullet points of things that you would like to see addressed so that @kevinwang827 at least has some directions? Thanks!

In the meantime, @kevinwang827, maybe look at the failing CI jobs as a starting point for things like code formatting issues.

[jfischer-no]

@jfischer-no There is nothing in this PR that call for this kind of rude language. It is clear to me that @kevinwang827 has done some homework before sending the pull request, and I'm sorry but saying that it's just throwing code into the project as if it was a trash can is simply not acceptable.

I disagree, there is nothing rude in my comment, and "throwing code into the project as if it were a trash can" is exactly what it is. There is absolutely nothing in that PR that could be acceptable, and it is just a factual description of what this PR is.

Can you please provide a couple bullet points of things that you would like to see addressed so that @kevinwang827 at least has some directions? Thanks!

Reading the documentation and understanding how the project is built is the first and necessary step to understanding why this PR makes no sense. It is not fair to others to spend huge amounts of time commenting on every single line of what is wrong with it.

[carlescufi]

@jfischer-no while your statement may be factual, there are many ways of expressing facts, and you chose one that can definitely be perceived as rude, as @kartben noted.

You could have said instead:
"Sorry, I am not sure I understand why you added a new, quectel-specific sample? Also serial drivers do not belong in subsys/usb, so that confused me as well. Perhaps you could explain what you are trying to achieve and we can then help you out with it?"