Add STM32MP13 support #87687

juickar · 2025-03-26T13:37:09Z

This PR adds the support for the STM32MP13 series.
It adds support of the STM32MP135F DK board

This PR includes the support of :

Cortex-A7
GPIO, UART, GIC and EXTI for the STM32MP135F DK board.

github-actions · 2025-03-26T13:37:58Z

Hello @juickar, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

github-actions · 2025-03-26T13:38:34Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_stm32	zephyrproject-rtos/hal_stm32@`4ec1fd2`	zephyrproject-rtos/hal_stm32@`def7e1a` (`main`)	zephyrproject-rtos/hal_stm32@4ec1fd2e..def7e1a0

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

boards/st/stm32mp135f_dk/doc/stm32mp135_dk.rst

maass-hamburg · 2025-03-26T13:55:30Z

boards/st/stm32mp135f_dk/doc/stm32mp135_dk.rst

+The STM32MP135F_DK Discovery board leverages the capacities of the STM32MP135
+multi-core processor,composed of a dual Cortex®-A7 and a single Cortex®-M4 core.
+Zephyr OS is ported to run on the Cortex®-M4 core.


the stm32mp135 has a Arm Cortex‑A7 and no Cortex-M4

kartben

a few comments left, looking good otherwise, thanks!

boards/st/stm32mp135f_dk/doc/index.rst

boards/st/stm32mp135f_dk/twister.yaml

etienne-lms

Few nitpicking comments.
Otherwise looks all good to me.

drivers/clock_control/clock_stm32_ll_mp13.c

boards/st/stm32mp135f_dk/stm32mp135f_dk.dts

kartben

+1 for docs

drivers/clock_control/clock_stm32_ll_mp13.c

Add STM32MP13 clock driver. Supported clocks are HSE, HSI, PLL1 and peripheral clock. Signed-off-by: Julien Racki <julien.racki@st.com> Co-authored-by: Arif Balik <arifbalik@outlook.com>

Put the flash in DDR 0xC0000000 Put the SRAM in DDR 0xD0000000 Signed-off-by: Julien Racki <julien.racki@st.com>

Add support for STM32MP135F DK board. Signed-off-by: Julien Racki <julien.racki@st.com>

etienne-lms

LGTM AFAICT

mathieuchopstm

LGTM with just a tiny cosmetic detail at arch level (i.e., don't bother making the change, can be fixed later):

mathieuchopstm · 2025-04-03T14:17:56Z

arch/arm/core/cortex_a_r/fault.c

+	case FSR_FS_TLB_CONFLICT_FAULT:
+		reason = K_ERR_ARM_TLB_CONFLICT_FAULT;
+		LOG_ERR("Table Conflict Fault @ 0x%08x", addr);
+		break;


Nits:

ARMv7-A/R Arch RefMan (DDI0406C) calls this a TLB conflict abort

TLB = Translation Lookaside Buffer rather than TBL = Table 🙂

Suggested change

case FSR_FS_TLB_CONFLICT_FAULT:

reason = K_ERR_ARM_TLB_CONFLICT_FAULT;

LOG_ERR("Table Conflict Fault @ 0x%08x", addr);

break;

case FSR_FS_TLB_CONFLICT_ABORT:

reason = K_ERR_ARM_TLB_CONFLICT_ABORT;

LOG_ERR("TLB Conflict Abort @ 0x%08x", addr);

break;

erwango · 2025-04-03T14:34:01Z

@nordicjm PTAL

github-actions · 2025-04-04T07:35:43Z

Hi @juickar!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

github-actions bot added platform: STM32 ST Micro STM32 area: Clock Control area: CMSIS-Core area: Build System area: ARM ARM (32-bit) Architecture area: Architectures labels Mar 26, 2025

github-actions bot requested review from bbolen, carlocaione, djiatsaf-st, erwango, FRASTM, galak, GeorgeCGV, ithinuel, marwaiehm-st, mathieuchopstm, MaureenHelm, microbuilder, stephanosio, tejlmand and wearyzen March 26, 2025 13:38

github-actions bot assigned wearyzen Mar 26, 2025

github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Mar 26, 2025

arnopo linked an issue Mar 26, 2025 that may be closed by this pull request

soc: st: stm32mp13xx series support #82701

Closed

arnopo mentioned this pull request Mar 26, 2025

soc: st: stm32mp13xx series support #82701

Closed

maass-hamburg requested changes Mar 26, 2025

View reviewed changes

juickar force-pushed the stm32mp135f_dk branch from 3d64224 to 9598672 Compare April 2, 2025 15:33

arnopo previously approved these changes Apr 3, 2025

View reviewed changes

arnopo requested review from etienne-lms, maass-hamburg, wearyzen, mathieuchopstm and kartben April 3, 2025 06:55

kartben requested changes Apr 3, 2025

View reviewed changes

boards/st/stm32mp135f_dk/doc/index.rst Outdated Show resolved Hide resolved

boards/st/stm32mp135f_dk/doc/index.rst Outdated Show resolved Hide resolved

boards/st/stm32mp135f_dk/twister.yaml Outdated Show resolved Hide resolved

etienne-lms reviewed Apr 3, 2025

View reviewed changes

drivers/clock_control/clock_stm32_ll_mp13.c Outdated Show resolved Hide resolved

boards/st/stm32mp135f_dk/stm32mp135f_dk.dts Show resolved Hide resolved

boards/st/stm32mp135f_dk/stm32mp135f_dk.dts Show resolved Hide resolved

juickar dismissed arnopo’s stale review via f3b9516 April 3, 2025 09:23

juickar force-pushed the stm32mp135f_dk branch from 9598672 to f3b9516 Compare April 3, 2025 09:23

kartben previously approved these changes Apr 3, 2025

View reviewed changes

etienne-lms reviewed Apr 3, 2025

View reviewed changes

drivers/clock_control/clock_stm32_ll_mp13.c Outdated Show resolved Hide resolved

juickar dismissed kartben’s stale review via 16a0f63 April 3, 2025 09:30

juickar force-pushed the stm32mp135f_dk branch from f3b9516 to 16a0f63 Compare April 3, 2025 09:30

juickar and others added 3 commits April 3, 2025 11:43

drivers: clock: Add stm32mp13 clock

ac3d4a2

Add STM32MP13 clock driver. Supported clocks are HSE, HSI, PLL1 and peripheral clock. Signed-off-by: Julien Racki <julien.racki@st.com> Co-authored-by: Arif Balik <arifbalik@outlook.com>

dts: arm: st: mp13: stm32mp13 new series with cortex A7

6ca2db6

Put the flash in DDR 0xC0000000 Put the SRAM in DDR 0xD0000000 Signed-off-by: Julien Racki <julien.racki@st.com>

boards: st: Add support for stm32mp135f_dk board

b78c51c

Add support for STM32MP135F DK board. Signed-off-by: Julien Racki <julien.racki@st.com>

juickar force-pushed the stm32mp135f_dk branch from 16a0f63 to b78c51c Compare April 3, 2025 09:44

etienne-lms approved these changes Apr 3, 2025

View reviewed changes

erwango approved these changes Apr 3, 2025

View reviewed changes

maass-hamburg approved these changes Apr 3, 2025

View reviewed changes

kartben approved these changes Apr 3, 2025

View reviewed changes

arnopo approved these changes Apr 3, 2025

View reviewed changes

wearyzen approved these changes Apr 3, 2025

View reviewed changes

mathieuchopstm approved these changes Apr 3, 2025

View reviewed changes

nordicjm approved these changes Apr 4, 2025

View reviewed changes

kartben merged commit ee6bb6e into zephyrproject-rtos:main Apr 4, 2025
30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add STM32MP13 support #87687

Add STM32MP13 support #87687

juickar commented Mar 26, 2025 •

edited

Loading

github-actions bot commented Mar 26, 2025

github-actions bot commented Mar 26, 2025 •

edited

Loading

maass-hamburg Mar 26, 2025

juickar Apr 1, 2025

kartben left a comment

etienne-lms left a comment

kartben left a comment

etienne-lms left a comment

mathieuchopstm left a comment

mathieuchopstm Apr 3, 2025

erwango commented Apr 3, 2025

github-actions bot commented Apr 4, 2025

Add STM32MP13 support #87687

Add STM32MP13 support #87687

Conversation

juickar commented Mar 26, 2025 • edited Loading

github-actions bot commented Mar 26, 2025

github-actions bot commented Mar 26, 2025 • edited Loading

maass-hamburg Mar 26, 2025

Choose a reason for hiding this comment

juickar Apr 1, 2025

Choose a reason for hiding this comment

kartben left a comment

Choose a reason for hiding this comment

etienne-lms left a comment

Choose a reason for hiding this comment

kartben left a comment

Choose a reason for hiding this comment

etienne-lms left a comment

Choose a reason for hiding this comment

mathieuchopstm left a comment

Choose a reason for hiding this comment

mathieuchopstm Apr 3, 2025

Choose a reason for hiding this comment

erwango commented Apr 3, 2025

github-actions bot commented Apr 4, 2025

juickar commented Mar 26, 2025 •

edited

Loading

github-actions bot commented Mar 26, 2025 •

edited

Loading