Bluetooth: Classic: Refactor query and deletion bonding information #87743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Bluetooth Host
github-actions
bot
requested review from
alwa-nordic,
gzh-terry,
hermabe,
jhedberg,
makeshi,
rugeGerritsen,
sjanc and
Thalley
lylezhu2012
force-pushed
the
br_classic_refactor_query_and_deletion_bonds
branch
from
9f2ad9d to
d0cec9a
Compare
jhedberg
previously approved these changes
Mar 27, 2025
lylezhu2012
force-pushed
the
br_classic_refactor_query_and_deletion_bonds
branch
from
d0cec9a to
4208a85
Compare
makeshi
reviewed
Mar 31, 2025
lylezhu2012
force-pushed
the
br_classic_refactor_query_and_deletion_bonds
branch
from
4208a85 to
c201fea
Compare
makeshi
approved these changes
Mar 31, 2025
jhedberg
approved these changes
Mar 31, 2025
In current implementation, the bonding information of classic is queried by calling the function `bt_foreach_bond()`. And the bonding information of classic is deleted by calling `bt_unpair()`. There are two issues if the LE and classic are bonded at same time for dual mode peer device. Issue 1, for the function `bt_foreach_bond()`, there are two bonding information will be found. But there is no way to find which bonding information belongs to LE or classic. Issue 2, For the function `bt_unpair()`, all bonding information will be deleted if the passed address is the public address. But there is no way to delete the bonding information of LE or classic. Remove the calling of function `bt_foreach_bond_br()` from the function `bt_foreach_bond()`. And rename it to `bt_br_foreach_bond()`, and public it as an API to query the bonding information of classic. Remove the calling of function `bt_keys_link_key_clear_addr()` from the function `bt_unpair()`. Add an API `bt_br_unpair()` to delete the bonding information of classic. Add a `br_bond_deleted` to structure `bt_conn_auth_info_cb` for classic. The callback will be triggered if the bonding information has been deleted by the function `bt_br_unpair()`. Add a `clear` shell command for classic to delete the bonding information. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
Add shell command `bonds` to list all the bonding information of classic. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
lylezhu2012
force-pushed
the
br_classic_refactor_query_and_deletion_bonds
branch
from
c201fea to
22b7fdc
Compare
|
Rebase the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation, the bonding information of classic is queried by calling the function
bt_foreach_bond(). And the bonding information of classic is deleted by callingbt_unpair().There are two issues if the LE and classic are bonded at same time for dual mode peer device.
Issue 1, for the function
bt_foreach_bond(), there are two bonding information will be found. But there is no way to find which bonding information belongs to LE or classic.Issue 2, For the function
bt_unpair(), all bonding information will be deleted if the passed address is the public address. But there is no way to delete the bonding information of LE or classic.Remove the calling of function
bt_foreach_bond_br()from the functionbt_foreach_bond(). And rename it tobt_br_foreach_bond(), and public it as an API to query the bonding information of classic.Remove the calling of function
bt_keys_link_key_clear_addr()from the functionbt_unpair(). Add an APIbt_br_unpair()to delete the bonding information of classic.Add a
br_bond_deletedto structurebt_conn_auth_info_cbfor classic. The callback will be triggered if the bonding information has been deleted by the functionbt_br_unpair().Add a
clearshell command for classic to delete the bonding information.bondsAdd shell command
bondsto list all the bonding information of classic.