Adding I2S Support for the RW612 #87773
Conversation
There was a problem hiding this comment.
Thanks @EmilioCBen
You have compliance issues to clean up. But the i2s_speed test works for me on both boards. And your changes look good to me. Thanks
EmilioCBen
force-pushed
the
fix/rw_soc_i2s_clock
branch
2 times, most recently
from
7fce624 to
62ae838
Compare
|
im not sure why did you split the board changes into two commit, neither of them work without the other, and both are just different parts of the code to enable i2s for the board, why not combine them to one commit |
boards/nxp/rd_rw612_bga/Kconfig
Outdated
| @@ -0,0 +1,5 @@ | |||
| # Copyright 2024 NXP | |||
There was a problem hiding this comment.
- Also there is an overlap with this PR: RW612: Add power init code for PM3 support #87594
There was a problem hiding this comment.
Thank you for making me aware of this PR I will stay in sync, also I will update the copyrights.
| #include <fsl_clock.h> | ||
| #include <fsl_power.h> | ||
| #include "fsl_io_mux.h" | ||
|
|
There was a problem hiding this comment.
You probably don't need a lot of these header files. Probably need only 1, can you please delete and check.
There was a problem hiding this comment.
Thank you for pointing this out, updated.
There was a problem hiding this comment.
I don't see a lot of iomux related API's used in this file. Probably fsl_common.h is what you need?
There was a problem hiding this comment.
I think your right, I will update the PR.
boards/nxp/rd_rw612_bga/init.c
Outdated
| @@ -0,0 +1,44 @@ | |||
| /* | |||
| * Copyright 2022, 2024 NXP | |||
| @@ -14,4 +14,5 @@ if(CONFIG_NXP_RW6XX_BOOT_HEADER) | |||
| zephyr_compile_definitions(BOARD_FLASH_SIZE=CONFIG_FLASH_SIZE*1024) | |||
| zephyr_library() | |||
| zephyr_library_sources(MX25U51245GZ4I00_FCB.c) | |||
| zephyr_library_sources(init.c) | |||
There was a problem hiding this comment.
This should be moved outside the CONFIG as we need this file even when we have a bootloader.
There was a problem hiding this comment.
Thank you again for pointing this out, updated.
There was a problem hiding this comment.
Thank you again for pointing this out, updated.
boards/nxp/frdm_rw612/init.c
Outdated
| @@ -0,0 +1,44 @@ | |||
| /* | |||
| * Copyright 2022, 2024 NXP | |||
There was a problem hiding this comment.
Same comments as rd_rw612_bga
EmilioCBen
force-pushed
the
fix/rw_soc_i2s_clock
branch
from
62ae838 to
54c1415
Compare
Sorry, I thought this would be better for clarity and since the second commit is what enables the support on the board dts I thought I separate why the init.c was included with the dts node being added. |
it would make more sense to put the loop test code in init.c in the same commit as enabling the test, and put the clocks in the same commit as all the other normal board enablement code |
EmilioCBen
force-pushed
the
fix/rw_soc_i2s_clock
branch
from
54c1415 to
561315b
Compare
That does make more sense I will update the PR to reflect this. |
EmilioCBen
force-pushed
the
fix/rw_soc_i2s_clock
branch
3 times, most recently
from
88462d3 to
6fc749a
Compare
Added I2S support for RW612. Signed-off-by: Emilio Benavente <emilio.benavente@nxp.com>
EmilioCBen
force-pushed
the
fix/rw_soc_i2s_clock
branch
from
6fc749a to
80321b8
Compare
boards/nxp/frdm_rw612/CMakeLists.txt
Outdated
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
|
|
||
| zephyr_library_sources(init.c) | ||
|
|
||
| if(CONFIG_NXP_RW6XX_BOOT_HEADER) | ||
| zephyr_compile_definitions(BOARD_FLASH_SIZE=CONFIG_FLASH_SIZE*1024) | ||
| zephyr_library() |
There was a problem hiding this comment.
This should move outside the if as well
There was a problem hiding this comment.
Sure that make sense, I can move this as well.
Added Internal pin connection for I2S Loopback testing when I2S is enabled. Added I2S testing support for RW612. Signed-off-by: Emilio Benavente <emilio.benavente@nxp.com>
EmilioCBen
force-pushed
the
fix/rw_soc_i2s_clock
branch
from
80321b8 to
0b51f61
Compare
Addresses #87239.