drivers: udc_nrf: refactor towards native driver #87954
Open
+1,293
−352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmon-nordic
force-pushed
the
udc-nrf-rework
branch
3 times, most recently
from
42bb38a to
31fdc26
Compare
The transfer is queued when buffer is available. There is no point in delaying the wait until SOF. The check is completely unnecessary. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
tmon-nordic
force-pushed
the
udc-nrf-rework
branch
from
31fdc26 to
3b4f366
Compare
This is preparatory commit for former nrfx USBD refactor. The refactor
towards native driver will only be performed on the udc driver (old USB
stack driver will continue to use nrf usbd common until it is removed).
Code is copied from nrf_usbd_common.c with minimal changes:
* nrf_usbd_common_irq_handler renamed to nrf_usbd_irq_handler
* all non-static nrf_usbd_common functions have prefix changed to
nrf_usbd_legacy
* functions not used by udc nrf driver are removed
* braces are moved inside #if to pass compliance checks
No functional changes.
Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
Post directly to driver queue because there is no longer shim separation. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
tmon-nordic
force-pushed
the
udc-nrf-rework
branch
4 times, most recently
from
1066727 to
45397eb
Compare
Use UDC endpoint state instead of the legacy hal state. Only functional change relates to overload condition (buffer is too small to hold data received on OUT endpoint). Previously the data would be completely discarded and udc driver error would occur (overload event was unhandled). Now buffer too small error is logged and as much data as possible is copied to buffer. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
Endpoint abort is guarded with DMA semaphore. The buffers can be freed by the caller immediately after endpoint is aborted because the driver won't access them anymore. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
There is no need in notifying the driver that OUT data has been received. This was only used for control transfers with OUT data stage because dma waiting bit was not set when enqueueing buffer to receive data stage. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
There is finite number of distinct events that are handled in thread context and the order of handling is flexible. Therefore use events instead of message queue because it is guaranteed to never get full. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
Use USB stack state instead of former HAL state to determine what to do with control transfer buffers. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no> busy
Arm OUT endpoints only when enqueueing first buffer. Disarm IN and OUT endpoints on endpoint disable. Prevent ISO endpoints from being armed twice before SOF. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
Zephyr USB maintainer Johann Fischer does not allow doxygen comments in udc drivers. Update the comments so the refactored driver can be merged. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
tmon-nordic
force-pushed
the
udc-nrf-rework
branch
from
45397eb to
d054b5d
Compare
Thalley
approved these changes
Apr 4, 2025
There was a problem hiding this comment.
From a quick test it seems to fix the issue mentioned in #84359 (comment)
@larsgk please try this PR with #84359 and verify as well
I have not done any review of the code changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework udc nrf driver to resolve virtually-impossible-to-fix issues resulting due to the arbitrary hal/shim separation. This is not complete refactor, but a solid step towards easy-to-understand and bug-free driver.