bluetooth: host: att: Remove superfluous functions and misleading checks #88043
+19
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra `bt_att_chan_req_send` does nothing but increases readability complexity. All checks are already performed by the caller. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
`att_sent` is removed as it does not provide any value. All checks are already performed in `att_on_sent_cb`, and keeping it only increases readability complexity. `att_sent` is removed as doesn't give any value. All checks are done already in `att_on_sent_cb`. It just increases readness complexity. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
PavelVPV
force-pushed
the
clean_up_att
branch
3 times, most recently
from
6a42fbc to
cfa5746
Compare
PavelVPV
changed the title
github-actions
bot
added
area: Bluetooth
area: Bluetooth Host
github-actions
bot
requested review from
alwa-nordic,
hermabe,
jhedberg,
rugeGerritsen,
sjanc and
Thalley
jhedberg
requested changes
Apr 3, 2025
jhedberg
previously approved these changes
Apr 3, 2025
`>= 0` was used when EATT support was implemented (zephyrproject-rtos#23199) because `bt_l2cap_chan_send` could return number of bytes sent. After PR zephyrproject-rtos#67528, `bt_l2cap_chan_send` doesn't return amount of bytes sent or any positive value, but either 0 or negative value. Thus `>= 0` is not needed. It also confusing when reading code, especially when the same check is not implemented in other cases where underlying function `chan_send` is used. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
jhedberg
approved these changes
Apr 3, 2025
Thalley
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
chan_req_sendandatt_sentas superfluous functions. They do nothing, but increase readability complexity. It also removes>= 0check forbt_att_chan_req_sendas currently only 0 is returned on success.