Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: charger: add initial support for the charger module found in AXP2101 MFD device #88125

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

drivers: charger: add initial support for the charger module found in AXP2101 MFD device #88125

wants to merge 3 commits into from

Conversation

valeriosetti
Copy link
Collaborator

@valeriosetti valeriosetti commented Apr 3, 2025 •
edited
Loading

This PR adds initial support for the charger module which is part of the AXP2101 MFD device. The same IC also implements regulators, but those are already supported in Zephyr.

Finally the DTS of the lilygo/twatch_s3 board is also extended to enable this driver.

Depends on #88053 in order to have CI fully green

@valeriosetti valeriosetti force-pushed the charger_axp2101 branch 6 times, most recently from cb97568 to fd77ae8 Compare April 7, 2025 07:56
@valeriosetti valeriosetti marked this pull request as ready for review April 7, 2025 07:56
@github-actions github-actions bot requested a review from rriveramcrus April 7, 2025 07:56
@rriveramcrus
Copy link
Collaborator

Overall this is looking really good, once the MISRA-C 2012 related fixes are in place I feel ready to approve.

8d321c8#diff-db5eebc0f089960f1220673dde2c861af4e2b36adca08183704729335562c2b5
A bonus item to address, if you have the time, would be to add an entry to tests/drivers/build_all/charger/i2c.dtsi as was done in this commit.

@teburd teburd self-requested a review April 9, 2025 23:30
@valeriosetti
drivers: charger: add charger support in X-Powers AXP2101
02f16d8 
AXP2101 is MFD device. Zephyr already support the regulator part. This
commit introduces intial support for the charger one.

Signed-off-by: Valerio Setti <vsetti@baylibre.com>
@valeriosetti
boards: twatch_s3: enable battery charger
016a83c 
Enable the battery charger module form the X-Powers AXP2101 IC.

Signed-off-by: Valerio Setti <vsetti@baylibre.com>
@valeriosetti
tests: drivers: build_all: add support for "x-powers,axp2101-charger"
1b1fd62 
Extend the *.dtsi file to include also an "x-powers,axp2101-charger"
instance.

Signed-off-by: Valerio Setti <vsetti@baylibre.com>
rriveramcrus
rriveramcrus approved these changes Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@rriveramcrus rriveramcrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rriveramcrus rriveramcrus rriveramcrus approved these changes

@teburd teburd Awaiting requested review from teburd

At least 2 approving reviews are required to merge this pull request.

Assignees

@rriveramcrus rriveramcrus

Labels
area: Charger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valeriosetti @rriveramcrus