drivers: video: formats: add most of the raw formats #88138
Conversation
josuah
added
area: API
include/zephyr/drivers/video.h
Outdated
| * | Yyyyyyyy | Yyyyyyyy | Yyyyyyyy | Yyyyyyyy | ... | ||
| * @endverbatim | ||
| */ | ||
| #define VIDEO_PIX_FMT_Y8 VIDEO_FOURCC('G', 'R', 'E', 'Y') |
There was a problem hiding this comment.
It seems confused between : _PIX_FMT_Y8I and _PIX_FMT_GREY.
I think it should be:
#define VIDEO_PIX_FMT_GREY VIDEO_FOURCC('G', 'R', 'E', 'Y')
There was a problem hiding this comment.
I sometimes have difficulties making a difference between what Linux status-quo and what Linux tries to move towards. I was borrowing Y8 from media bus.
I added a hint in the documentation that this is nothing special, just following the FOURCC naming.
include/zephyr/drivers/video.h
Outdated
| * | Gggggggg | Rrrrrrrr | Gggggggg | Rrrrrrrr | rrggrrgg | ... | ||
| * @endverbatim | ||
| */ | ||
| #define VIDEO_PIX_FMT_SBGGR10P VIDEO_FOURCC('p', 'R', 'A', 'A') |
There was a problem hiding this comment.
FOURCC seems wrong, should be:
#define VIDEO_PIX_FMT_SBGGR10P VIDEO_FOURCC('p', 'B', 'A', 'A')
ref : https://elixir.bootlin.com/linux/v6.11.1/source/include/uapi/linux/videodev2
There was a problem hiding this comment.
-#define VIDEO_PIX_FMT_SBGGR10P VIDEO_FOURCC('p', 'R', 'A', 'A')
+#define VIDEO_PIX_FMT_SBGGR10P VIDEO_FOURCC('p', 'B', 'A', 'A')ok
In addition to the 8-bit, introduce all the other bayer formats described by MIPI-CSI2 specification. The 8-bit bayer formats description is shortened to just 4 bytes like the other formats, to help intuition while comparing the different formats. Signed-off-by: Josuah Demangeon <me@josuah.net>
|
Sorry about that, I think I copy-pasted the RGGB8 etc formats from Zephyr and looked at the documentation (in opposite order) for adding the FOURCC... I could have checked better... Thank you for the extra pair of vigilant eyes. |
Add the grayscale formats in the same packing as defined by MIPI. Signed-off-by: Josuah Demangeon <me@josuah.net>
|
Force-push:
|
Downstream:
This adds the raw formats in the same packing as defined by MIPI, with the naming that follows the Linux Kernel: