drivers: gpio: rts5912 remap gpio number #95165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-zephyr
reviewed
Sep 3, 2025
| @@ -39,4 +39,112 @@ | |||
| /** Interrupt Mask since rts5912 does not support GPIO_INT_LEVELS_LOGICAL*/ | |||
| #define RTS5912_GPIO_INTR_MASK (1U << 21 | 1U << 22 | 1U << 24 | 1U << 25 | 1U << 26) | |||
|
|
|||
| /** GPIO number map between spec and zephyr */ | |||
There was a problem hiding this comment.
Non-blocking suggestion "Map GPIO signal name to devicetree binding."
Please also add a comment describing how to use this macro. See dt-bindings/gpio/microchip-xec-gpio.h for an example.
There was a problem hiding this comment.
Thanks for the advice, I added it.
| @@ -39,4 +39,112 @@ | |||
| /** Interrupt Mask since rts5912 does not support GPIO_INT_LEVELS_LOGICAL*/ | |||
| #define RTS5912_GPIO_INTR_MASK (1U << 21 | 1U << 22 | 1U << 24 | 1U << 25 | 1U << 26) | |||
|
|
|||
| /** GPIO number map between spec and zephyr */ | |||
| #define RTS5912_GPIO_NUM_000 &gpioa 0 | |||
There was a problem hiding this comment.
Considering the symbol name is just GPIO000, I suggest dropping the _NUM_ designator.
Suggested change
| #define RTS5912_GPIO_NUM_000 &gpioa 0 | |
| #define RTS5912_GPIO000 &gpioa 0 |
There was a problem hiding this comment.
Thanks for the advice, the _NUM_ is removed.
elmo9999
force-pushed
the
gpio_remap
branch
2 times, most recently
from
16035e8 to
7bde92c
Compare
Provide a map from RTS5912_GPIO_NUM_000 to RTS5912_GPIO_NUM_131 for appication call be easier read. For example: Used: <&gpiog 6 (GPIO_OUTPUT)> Now: <RTS5912_GPIO_NUM_102 (GPIO_OUTPUT)> Signed-off-by: Elmo Lan <elmo_lan@realtek.com>
|
keith-zephyr
approved these changes
Sep 5, 2025
JasonLin-RealTek
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a map from RTS5912_GPIO_NUM_000 to RTS5912_GPIO_NUM_131
for appication call be easier read.
For example:
Used: <&gpiog 6 (GPIO_OUTPUT)>
Now: <RTS5912_GPIO_NUM_102 (GPIO_OUTPUT)>