Skip to content
Check Tests and Documentation

#535 Enable adding non-root NOC(ICA) certificates #1797

Sign in to view logs

#535 Enable adding non-root NOC(ICA) certificates

#535 Enable adding non-root NOC(ICA) certificates #1797

Triggered via pull request March 4, 2024 15:06
@AbdulboisAbdulbois
opened #546
#535-Add-ICA-Certificates
Status Failure
Total duration 9m 33s
Artifacts –

verify.yml

on: pull_request
changes
7s
changes
Check linter issues with golangci-lint tool
2m 2s
Check linter issues with golangci-lint tool
Run actionlint tool to verify lint issues in GitHub actions
0s
Run actionlint tool to verify lint issues in GitHub actions
Run markdown-link-check tool to verify link issues
0s
Run markdown-link-check tool to verify link issues
Run PySpelling tool to verify spelling issues
0s
Run PySpelling tool to verify spelling issues
Integration tests
8m 53s
Integration tests
Check unit tests
0s
Check unit tests
check
4s
check
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 3 warnings
Check linter issues with golangci-lint tool: x/pki/client/cli/query_noc_certificates_test.go#L4
commentFormatting: put a space between `//` and comment text (gocritic)
Check linter issues with golangci-lint tool: x/pki/keeper/noc_certificates.go#L74
Comment should end in a period (godot)
Check linter issues with golangci-lint tool: x/pki/types/key_noc_certificates.go#L8
Comment should end in a period (godot)
Check linter issues with golangci-lint tool: x/pki/types/key_noc_certificates.go#L12
Comment should end in a period (godot)
Check linter issues with golangci-lint tool: x/pki/handler_add_noc_cert_test.go#L341
`addNocRootCertificate` - `pemCert` always receives `testconstants.NocRootCert1` (`"-----BEGIN CERTIFICATE-----\nMIICRzCCAe2gAwIBAgIBATAKBggqhkjOPQQDAjC...`) (unparam)
Check linter issues with golangci-lint tool: x/pki/keeper/grpc_query_noc_certificates.go#L34
return with no blank line before (nlreturn)
Check linter issues with golangci-lint tool: x/pki/keeper/noc_certificates_test.go#L26
return with no blank line before (nlreturn)
Check linter issues with golangci-lint tool: x/pki/types/message_add_noc_x_509_cert.go#L33
return with no blank line before (nlreturn)
Check linter issues with golangci-lint tool
issues found
Integration tests
Process completed with exit code 1.
check
Process completed with exit code 1.
changes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check linter issues with golangci-lint tool
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v3, golangci/golangci-lint-action@v3.6.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Integration tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v3, actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.