Skip to content
Check Tests and Documentation

#524 Enable revocation of NOC root certificates #1819

Sign in to view logs

#524 Enable revocation of NOC root certificates

#524 Enable revocation of NOC root certificates #1819

Triggered via pull request March 13, 2024 06:48
@AbdulboisAbdulbois
synchronize #550
#524-Revocation-of-NOC-root-certs
Status Cancelled
Total duration 6m 54s
Artifacts –

verify.yml

on: pull_request
changes
4s
changes
Check linter issues with golangci-lint tool
40s
Check linter issues with golangci-lint tool
Run actionlint tool to verify lint issues in GitHub actions
0s
Run actionlint tool to verify lint issues in GitHub actions
Run markdown-link-check tool to verify link issues
41s
Run markdown-link-check tool to verify link issues
Run PySpelling tool to verify spelling issues
8s
Run PySpelling tool to verify spelling issues
Integration tests
6m 25s
Integration tests
Check unit tests
0s
Check unit tests
check
3s
check
Fit to window
Zoom out
Zoom in

Annotations

13 errors and 6 warnings
Check linter issues with golangci-lint tool: x/pki/keeper/revoked_noc_root_certificates.go#L10
Comment should end in a period (godot)
Check linter issues with golangci-lint tool: x/pki/keeper/revoked_noc_root_certificates.go#L49
Comment should end in a period (godot)
Check linter issues with golangci-lint tool: x/pki/keeper/revoked_noc_root_certificates.go#L70
Comment should end in a period (godot)
Check linter issues with golangci-lint tool: x/pki/types/message_revoke_noc_root_x_509_cert_test.go#L3
File is not `goimports`-ed (goimports)
Check linter issues with golangci-lint tool: x/pki/keeper/msg_server_revoke_noc_root_x_509_cert.go#L71
S1016: should convert certificates (type github.com/zigbee-alliance/distributed-compliance-ledger/x/pki/types.ApprovedCertificates) to github.com/zigbee-alliance/distributed-compliance-ledger/x/pki/types.RevokedNocRootCertificates instead of using struct literal (gosimple)
Check linter issues with golangci-lint tool: x/pki/handler_revoke_noc_root_cert_test.go#L247
ineffectual assignment to err (ineffassign)
Check linter issues with golangci-lint tool: x/pki/handler_revoke_noc_root_cert_test.go#L442
ineffectual assignment to err (ineffassign)
Check linter issues with golangci-lint tool: x/pki/handler_revoke_noc_root_cert_test.go#L539
ineffectual assignment to err (ineffassign)
Check linter issues with golangci-lint tool: x/pki/keeper/grpc_query_revoked_noc_root_certificates.go#L34
return with no blank line before (nlreturn)
Check linter issues with golangci-lint tool: x/pki/keeper/msg_server_revoke_noc_root_x_509_cert.go#L132
return with no blank line before (nlreturn)
Integration tests
The run was canceled by @Abdulbois.
Integration tests
The operation was canceled.
check
Process completed with exit code 1.
changes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run PySpelling tool to verify spelling issues
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run markdown-link-check tool to verify link issues
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check linter issues with golangci-lint tool
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v3, golangci/golangci-lint-action@v3.6.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check linter issues with golangci-lint tool: x/pki/handler_revoke_noc_root_cert_test.go#L552
var-naming: func parameter subjectKeyId should be subjectKeyID (revive)
Check linter issues with golangci-lint tool: x/pki/client/cli/query_revoked_noc_root_certificates_test.go#L55
var-naming: struct field idSubjectKeyId should be idSubjectKeyID (revive)