Skip to content
Check Tests and Documentation

#524 Enable revocation of NOC root certificates #1820

Sign in to view logs

#524 Enable revocation of NOC root certificates

#524 Enable revocation of NOC root certificates #1820

Triggered via pull request March 13, 2024 06:55
@AbdulboisAbdulbois
synchronize #550
#524-Revocation-of-NOC-root-certs
Status Cancelled
Total duration 11m 49s
Artifacts –

verify.yml

on: pull_request
changes
7s
changes
Check linter issues with golangci-lint tool
49s
Check linter issues with golangci-lint tool
Run actionlint tool to verify lint issues in GitHub actions
0s
Run actionlint tool to verify lint issues in GitHub actions
Run markdown-link-check tool to verify link issues
46s
Run markdown-link-check tool to verify link issues
Run PySpelling tool to verify spelling issues
7s
Run PySpelling tool to verify spelling issues
Integration tests
11m 19s
Integration tests
Check unit tests
0s
Check unit tests
check
1s
check
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 4 warnings
Check linter issues with golangci-lint tool: x/pki/keeper/revoked_noc_root_certificates.go#L85
Comment should end in a period (godot)
Check linter issues with golangci-lint tool: x/pki/keeper/grpc_query_revoked_noc_root_certificates_test.go#L18
Comment should end in a period (godot)
Check linter issues with golangci-lint tool: x/pki/keeper/revoked_noc_root_certificates_test.go#L15
Comment should end in a period (godot)
Check linter issues with golangci-lint tool: x/pki/types/message_revoke_noc_root_x_509_cert_test.go#L3
File is not `goimports`-ed (goimports)
Check linter issues with golangci-lint tool: x/pki/handler_revoke_noc_root_cert_test.go#L552
`queryRevokedNocRootCertificates` - `subject` always receives `testconstants.NocRootCert1Subject` (`"MHoxCzAJBgNVBAYTAlVaMRMwEQYDVQQIDApTb21lIFN0YXRlMREwDwYDVQQHDAhUYXNo...`) (unparam)
Check linter issues with golangci-lint tool: x/pki/keeper/msg_server_revoke_noc_root_x_509_cert.go#L71
S1016: should convert certificates (type github.com/zigbee-alliance/distributed-compliance-ledger/x/pki/types.ApprovedCertificates) to github.com/zigbee-alliance/distributed-compliance-ledger/x/pki/types.RevokedNocRootCertificates instead of using struct literal (gosimple)
Check linter issues with golangci-lint tool: x/pki/client/cli/query_revoked_noc_root_certificates_test.go#L42
return with no blank line before (nlreturn)
Check linter issues with golangci-lint tool
issues found
Integration tests
The run was canceled by @Abdulbois.
Integration tests
The operation was canceled.
check
Process completed with exit code 1.
changes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run PySpelling tool to verify spelling issues
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run markdown-link-check tool to verify link issues
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check linter issues with golangci-lint tool
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v3, golangci/golangci-lint-action@v3.6.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.