Skip to content

Js parse engine #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Js parse engine #99

wants to merge 3 commits into from
+130 −17

Conversation

pungggi
Copy link
Contributor

@pungggi pungggi commented Nov 16, 2017

This enables #98

pungggi
pungggi commented Nov 16, 2017
View reviewed changes
src/parse-engines/types/js-parse-engine.ts
}
}

cssToParse = cssToParse.replace(/(\$\{[\s]*.*?[\s]*\})/gmi, '0');
Copy link
Contributor Author

@pungggi pungggi Nov 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line (26) is because it failes to parse when a variable like ${myVar} is inside the template literal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pungggi