Gitbook page deployment workflow PR #961
pmd.yml
on: pull_request
PMD Static Code Analysis
24s
Annotations
10 errors and 10 warnings
Logger calls should be surrounded by log level guards.:
common/client/src/main/java/zingg/common/client/Client.java#L157
Whenever using a log level, one should check if it is actually enabled, or
otherwise skip the associate String creation and manipulation, as well as any method calls.
An alternative to checking the log level are substituting parameters, formatters or lazy logging
with lambdas. The available alternatives depend on the actual logging framework.
GuardLogStatement (Priority: 2, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#guardlogstatement
|
Logger calls should be surrounded by log level guards.:
common/client/src/main/java/zingg/common/client/Client.java#L152
Whenever using a log level, one should check if it is actually enabled, or
otherwise skip the associate String creation and manipulation, as well as any method calls.
An alternative to checking the log level are substituting parameters, formatters or lazy logging
with lambdas. The available alternatives depend on the actual logging framework.
GuardLogStatement (Priority: 2, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#guardlogstatement
|
Logger calls should be surrounded by log level guards.:
common/client/src/main/java/zingg/common/client/Client.java#L84
Whenever using a log level, one should check if it is actually enabled, or
otherwise skip the associate String creation and manipulation, as well as any method calls.
An alternative to checking the log level are substituting parameters, formatters or lazy logging
with lambdas. The available alternatives depend on the actual logging framework.
GuardLogStatement (Priority: 2, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#guardlogstatement
|
Logger calls should be surrounded by log level guards.:
common/client/src/main/java/zingg/common/client/Client.java#L78
Whenever using a log level, one should check if it is actually enabled, or
otherwise skip the associate String creation and manipulation, as well as any method calls.
An alternative to checking the log level are substituting parameters, formatters or lazy logging
with lambdas. The available alternatives depend on the actual logging framework.
GuardLogStatement (Priority: 2, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#guardlogstatement
|
Logger calls should be surrounded by log level guards.:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L168
Whenever using a log level, one should check if it is actually enabled, or
otherwise skip the associate String creation and manipulation, as well as any method calls.
An alternative to checking the log level are substituting parameters, formatters or lazy logging
with lambdas. The available alternatives depend on the actual logging framework.
GuardLogStatement (Priority: 2, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#guardlogstatement
|
Logger calls should be surrounded by log level guards.:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L141
Whenever using a log level, one should check if it is actually enabled, or
otherwise skip the associate String creation and manipulation, as well as any method calls.
An alternative to checking the log level are substituting parameters, formatters or lazy logging
with lambdas. The available alternatives depend on the actual logging framework.
GuardLogStatement (Priority: 2, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#guardlogstatement
|
Logger calls should be surrounded by log level guards.:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L128
Whenever using a log level, one should check if it is actually enabled, or
otherwise skip the associate String creation and manipulation, as well as any method calls.
An alternative to checking the log level are substituting parameters, formatters or lazy logging
with lambdas. The available alternatives depend on the actual logging framework.
GuardLogStatement (Priority: 2, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#guardlogstatement
|
Logger calls should be surrounded by log level guards.:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L99
Whenever using a log level, one should check if it is actually enabled, or
otherwise skip the associate String creation and manipulation, as well as any method calls.
An alternative to checking the log level are substituting parameters, formatters or lazy logging
with lambdas. The available alternatives depend on the actual logging framework.
GuardLogStatement (Priority: 2, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#guardlogstatement
|
Logger calls should be surrounded by log level guards.:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L74
Whenever using a log level, one should check if it is actually enabled, or
otherwise skip the associate String creation and manipulation, as well as any method calls.
An alternative to checking the log level are substituting parameters, formatters or lazy logging
with lambdas. The available alternatives depend on the actual logging framework.
GuardLogStatement (Priority: 2, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#guardlogstatement
|
Logger calls should be surrounded by log level guards.:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L68
Whenever using a log level, one should check if it is actually enabled, or
otherwise skip the associate String creation and manipulation, as well as any method calls.
An alternative to checking the log level are substituting parameters, formatters or lazy logging
with lambdas. The available alternatives depend on the actual logging framework.
GuardLogStatement (Priority: 2, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#guardlogstatement
|
Logger should be defined private static final and have the correct class:
common/client/src/main/java/zingg/common/client/Client.java#L34
A logger should normally be defined private static final and be associated with the correct class.
`private final Log log;` is also allowed for rare cases where loggers need to be passed around,
with the restriction that the logger needs to be passed into the constructor.
ProperLogger (Priority: 3, Ruleset: Error Prone)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_errorprone.html#properlogger
|
Thrown exception does not preserve the stack trace of exception 'e' on all code paths:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L203
Reports exceptions that are thrown from within a catch block, yet don't refer to the
exception parameter declared by that catch block. The stack trace of the original
exception could be lost, which makes the thrown exception less informative.
To preserve the stack trace, the original exception may be used as the cause of
the new exception, using `Throwable#initCause`, or passed as a constructor argument
to the new exception. It may also be preserved using `Throwable#addSuppressed`.
The rule actually assumes that any method or constructor that takes the original
exception as argument preserves the original stack trace.
The rule allows `InvocationTargetException` and `PrivilegedActionException` to be
replaced by their cause exception. The discarded part of the stack trace is in those
cases only JDK-internal code, which is not very useful. The rule also ignores exceptions
whose name starts with `ignored`.
PreserveStackTrace (Priority: 3, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#preservestacktrace
|
Thrown exception does not preserve the stack trace of exception 'e' on all code paths:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L189
Reports exceptions that are thrown from within a catch block, yet don't refer to the
exception parameter declared by that catch block. The stack trace of the original
exception could be lost, which makes the thrown exception less informative.
To preserve the stack trace, the original exception may be used as the cause of
the new exception, using `Throwable#initCause`, or passed as a constructor argument
to the new exception. It may also be preserved using `Throwable#addSuppressed`.
The rule actually assumes that any method or constructor that takes the original
exception as argument preserves the original stack trace.
The rule allows `InvocationTargetException` and `PrivilegedActionException` to be
replaced by their cause exception. The discarded part of the stack trace is in those
cases only JDK-internal code, which is not very useful. The rule also ignores exceptions
whose name starts with `ignored`.
PreserveStackTrace (Priority: 3, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#preservestacktrace
|
Position literals first in String comparisons:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L162
Position literals first in all String comparisons, if the second argument is null then NullPointerExceptions
can be avoided, they will just return false. Note that switching literal positions for compareTo and
compareToIgnoreCase may change the result, see examples.
Note that compile-time constant strings are treated like literals. This is because they are inlined into
the class file, are necessarily non-null, and therefore cannot cause an NPE at runtime.
LiteralsFirstInComparisons (Priority: 3, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#literalsfirstincomparisons
|
Thrown exception does not preserve the stack trace of exception 'e' on all code paths:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L149
Reports exceptions that are thrown from within a catch block, yet don't refer to the
exception parameter declared by that catch block. The stack trace of the original
exception could be lost, which makes the thrown exception less informative.
To preserve the stack trace, the original exception may be used as the cause of
the new exception, using `Throwable#initCause`, or passed as a constructor argument
to the new exception. It may also be preserved using `Throwable#addSuppressed`.
The rule actually assumes that any method or constructor that takes the original
exception as argument preserves the original stack trace.
The rule allows `InvocationTargetException` and `PrivilegedActionException` to be
replaced by their cause exception. The discarded part of the stack trace is in those
cases only JDK-internal code, which is not very useful. The rule also ignores exceptions
whose name starts with `ignored`.
PreserveStackTrace (Priority: 3, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#preservestacktrace
|
Thrown exception does not preserve the stack trace of exception 'e' on all code paths:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L133
Reports exceptions that are thrown from within a catch block, yet don't refer to the
exception parameter declared by that catch block. The stack trace of the original
exception could be lost, which makes the thrown exception less informative.
To preserve the stack trace, the original exception may be used as the cause of
the new exception, using `Throwable#initCause`, or passed as a constructor argument
to the new exception. It may also be preserved using `Throwable#addSuppressed`.
The rule actually assumes that any method or constructor that takes the original
exception as argument preserves the original stack trace.
The rule allows `InvocationTargetException` and `PrivilegedActionException` to be
replaced by their cause exception. The discarded part of the stack trace is in those
cases only JDK-internal code, which is not very useful. The rule also ignores exceptions
whose name starts with `ignored`.
PreserveStackTrace (Priority: 3, Ruleset: Best Practices)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_bestpractices.html#preservestacktrace
|
Logger should be defined private static final and have the correct class:
common/client/src/main/java/zingg/common/client/ArgumentsUtil.java#L27
A logger should normally be defined private static final and be associated with the correct class.
`private final Log log;` is also allowed for rare cases where loggers need to be passed around,
with the restriction that the logger needs to be passed into the constructor.
ProperLogger (Priority: 3, Ruleset: Error Prone)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_errorprone.html#properlogger
|
Document empty constructor:
common/client/src/main/java/zingg/common/client/Arguments.java#L112
Uncommented Empty Constructor finds instances where a constructor does not
contain statements, but there is no comment. By explicitly commenting empty
constructors it is easier to distinguish between intentional (commented)
and unintentional empty constructors.
UncommentedEmptyConstructor (Priority: 3, Ruleset: Documentation)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_documentation.html#uncommentedemptyconstructor
|
Avoid unnecessary constructors - the compiler will generate these for you:
common/client/src/main/java/zingg/common/client/Arguments.java#L112
This rule detects when a constructor is not necessary; i.e., when there is only one constructor and the
constructor is identical to the default constructor. The default constructor should has same access
modifier as the declaring class. In an enum type, the default constructor is implicitly private.
UnnecessaryConstructor (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_codestyle.html#unnecessaryconstructor
|
Logger should be defined private static final and have the correct class:
common/client/src/main/java/zingg/common/client/Arguments.java#L107
A logger should normally be defined private static final and be associated with the correct class.
`private final Log log;` is also allowed for rare cases where loggers need to be passed around,
with the restriction that the logger needs to be passed into the constructor.
ProperLogger (Priority: 3, Ruleset: Error Prone)
https://docs.pmd-code.org/pmd-doc-7.12.0/pmd_rules_java_errorprone.html#properlogger
|
Artifacts
Produced during runtime
Name | Size | Digest | |
---|---|---|---|
PMD Report
Expired
|
50 KB |
sha256:77f6b015733b81219322f6432da29b3ea9ce974fd019a7b3a56256825ba394af
|
|