add default slot and keys recognition #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatolysergeev
commented
Feb 9, 2023
| def encode(data: Iterable[A])(implicit codec: BinaryCodec): Chunk[RespValue.BulkString] = | ||
| data.foldLeft(Chunk.empty: Chunk[RespValue.BulkString])((acc, a) => acc ++ input.encode(a)) | ||
| def encode(data: Iterable[A])(implicit codec: BinaryCodec): RespCommand = | ||
| data.foldLeft(RespCommand.empty)((acc, a) => acc ++ input.encode(a)) | ||
| } | ||
|
|
||
| final case class EvalInput[-K, -V](inputK: Input[K], inputV: Input[V]) extends Input[(String, Chunk[K], Chunk[V])] { |
There was a problem hiding this comment.
Controversial idea. What Is interface ideally wanted: inputK would have type KeyInput[K] that inherit Input[K] and we can translate there any dependency, but we cannot to do that cause we have to have contramap that in the inherited interface that return main trait Input. 🤔
@mijicd What do you think?
There was a problem hiding this comment.
I am not sure about that one. Can you draft some poc and let's see what are the pros and cons?
anatolysergeev
force-pushed
the
add-default-slot
branch
from
7906aed to
10d3577
Compare
mijicd
requested changes
Feb 15, 2023
anatolysergeev
force-pushed
the
add-default-slot
branch
from
c179d43 to
a8e1677
Compare
anatolysergeev
force-pushed
the
add-default-slot
branch
from
a8e1677 to
a62b266
Compare
mijicd
approved these changes
Mar 16, 2023
| @@ -27,7 +27,7 @@ trait BaseSpec extends ZIOSpecDefault { | |||
|
|
|||
| /* TODO | |||
| * We can try to support the most unsupported commands for cluster with: | |||
| * - default connection for commands without a key and for multiple key commands with | |||
| * - [DONE] default connection for commands without a key and for multiple key commands with | |||
There was a problem hiding this comment.
I guess we can remove the [DONE] :)
| def encode(data: Iterable[A])(implicit codec: BinaryCodec): Chunk[RespValue.BulkString] = | ||
| data.foldLeft(Chunk.empty: Chunk[RespValue.BulkString])((acc, a) => acc ++ input.encode(a)) | ||
| def encode(data: Iterable[A])(implicit codec: BinaryCodec): RespCommand = | ||
| data.foldLeft(RespCommand.empty)((acc, a) => acc ++ input.encode(a)) | ||
| } | ||
|
|
||
| final case class EvalInput[-K, -V](inputK: Input[K], inputV: Input[V]) extends Input[(String, Chunk[K], Chunk[V])] { |
There was a problem hiding this comment.
I am not sure about that one. Can you draft some poc and let's see what are the pros and cons?
Comment on lines
+10
to
+11
| val key = RespArgument.Key("hello world") | ||
| assertTrue(15332 == key.asCRC16) |
There was a problem hiding this comment.
Nitpick (I'm fine with leaving it as it is as well):
Suggested change
| val key = RespArgument.Key("hello world") | |
| assertTrue(15332 == key.asCRC16) | |
| assertTrue(15332 == RespArgument.Key("hello world").asCRC16) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add default connection for commands without a key and for multiple key commands with the limitation that all keys have to be in the same slot
#673