ci: change tar command on macOS runners #540
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be some weird behaviour going on when creating compressed tarballs with `bsdtar` this way (redirecting stdout). The produced files seems OK, but `gzip` itself struggles to decompress it without errors, resulting in a "trailing garbage ignored" error message and exit code 2 (it still decompresses the file just fine though). This error doesn't surface when decompressing using `bsdtar` directly, but it does when using `gnutar`. See mason-org/mason-registry#9775. If you have a Mac you should be able to reproduce this assuming `tar -> bsdtar` and that you have `gnutar` installed as `gtar`. ```sh $ echo Hello > file $ tar -cvz file > archive.tar.gz $ gzip -d -c archive.tar.gz > /dev/null # exit code 2 and gzip: archive.tar.gz: trailing garbage ignored # Method 1: Create tarball first and then gzip $ tar -cv file > archive.tar $ gzip archive.tar $ gzip -d -c archive.tar.gz > /dev/null # works fine! # Method 2: Create compressed tarball with the -f flag $ tar -czf archive.tar.gz file $ gzip -d -c archive.tar.gz > /dev/null # works fine! ```
williamboman
force-pushed
the
fix/macos-archives
branch
from
dc8ce32 to
8931553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be some weird behaviour going on when creating compressed
tarballs with
bsdtarthis way (redirecting stdout). The produced filesseems OK, but
gzipitself struggles to decompress it without errors,resulting in a "trailing garbage ignored" error message and exit code 2
(it still decompresses the file just fine though). This error doesn't
surface when decompressing using
bsdtardirectly, but it does whenusing
gnutar.See mason-org/mason-registry#9775.
If you have a Mac you should be able to reproduce this assuming
tar -> bsdtarand that you havegnutarinstalled asgtar.I figured I'd open a PR since I found this somewhat interesting and
spent some time debugging it. Not entirely sure I've even found the root
cause but I believe this should help.
On my system this is the hexdump difference: https://www.diffchecker.com/z7Xqcfu8/. Right side is redirecting stdout, left side is using
-f.