Feat/curve/jacobian scalar mul #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moven0831
approved these changes
Jan 17, 2025
Comment on lines
+176
to
+179
| Jacobian jacobian_scalar_mul( | ||
| Jacobian point, | ||
| uint scalar | ||
| ) { |
There was a problem hiding this comment.
The scalar used here is constrained by the default GPU word size, which is 32-bit. Note that this function is suitable for MSM use cases because the scalar fragments involved in MSM are relatively small. However, for larger scalars, this may produce incorrect results.
Comment on lines
+53
to
+60
| if (is_jacobian_zero(a)) { | ||
| return b; | ||
| } | ||
| if (is_jacobian_zero(b)) { | ||
| return a; | ||
| } | ||
| if (a == b) return jacobian_dbl_2009_l(a, p); | ||
|
|
There was a problem hiding this comment.
Potential acceleration can be achieved by moving the condition checks directly into the MSM logic
Comment on lines
+180
to
+186
| // Handle special cases first | ||
| if (scalar == 0 || is_bigint_zero(point.z)) { | ||
| return get_bn254_zero_mont(); | ||
| } | ||
| if (scalar == 1) { | ||
| return point; | ||
| } |
There was a problem hiding this comment.
Potential acceleration can be achieved by moving the condition checks directly into the MSM logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new functions and tests to improve the functionality and robustness of the Jacobian curve arithmetic in the Metal shader implementation. Key changes include the addition of new equality and zero-check functions, a new scalar multiplication function, and the restructuring and enhancement of existing tests.
New functions:
bigint_eqandis_bigint_zerofunctions tobigint.metalfor BigInt equality and zero checks.jacobian_dbl_2009_landjacobian_scalar_mulfunctions injacobian.metalto handle point doubling and scalar multiplication on Jacobian curves. [1] [2]jacobian_eqandis_jacobian_zerofunctions toutils.metalfor Jacobian equality and zero checks.Enhancements to operators:
==operator forBigIntandJacobiantypes to use the newly added equality functions. [1] [2]New and updated tests:
jacobian_add_2007_b1.rs.jacobian_scalar_mul.rsfor testing scalar multiplication on Jacobian curves.mod.rsto include the new test module for scalar multiplication.These changes enhance the functionality and reliability of the Metal shader implementation for elliptic curve operations.