Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify instances of "additionals" -> "additional" when referring to the section as a whole #487

Merged
merged 18 commits into from
Dec 22, 2024

Conversation

phillip-stephens
Copy link
Contributor

@phillip-stephens phillip-stephens commented Dec 18, 2024

Resolves #484

RFC 1035 - refers to the Additional section in the singular.

This PR fixes that so our output sections align with the RFC. I've left other instances of additionals in the code since it makes the code more readable if you refer to a set of items in the plural.

@phillip-stephens phillip-stephens marked this pull request as ready for review December 18, 2024 21:10
@phillip-stephens phillip-stephens requested a review from a team as a code owner December 18, 2024 21:10
@phillip-stephens phillip-stephens changed the title Unify all instances of "additionals" -> "additional" Unify instances of "additionals" -> "additional" Dec 18, 2024
@phillip-stephens phillip-stephens changed the title Unify instances of "additionals" -> "additional" Unify instances of "additionals" -> "additional" when referring to the section as a whole Dec 18, 2024
src/cli/modules.go Outdated Show resolved Hide resolved
@zakird zakird merged commit c80ee63 into main Dec 22, 2024
3 checks passed
@zakird zakird deleted the phillip/484-additional branch December 22, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Pluralization for Additional Section
2 participants