-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify instances of "additionals" -> "additional" when referring to the section as a whole #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d755d3e.
…s of authority records in the code
phillip-stephens
changed the title
Unify all instances of "additionals" -> "additional"
Unify instances of "additionals" -> "additional"
Dec 18, 2024
phillip-stephens
changed the title
Unify instances of "additionals" -> "additional"
Unify instances of "additionals" -> "additional" when referring to the section as a whole
Dec 18, 2024
zakird
approved these changes
Dec 18, 2024
This reverts commit c6fe501.
zakird
reviewed
Dec 20, 2024
zakird
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #484
RFC 1035 - refers to the
Additional
section in the singular.This PR fixes that so our output sections align with the RFC. I've left other instances of
additionals
in the code since it makes the code more readable if you refer to a set of items in the plural.