NW6 | Nazanin-Saedi | HTML-CSS | Module-Project |Karma #651
Conversation
✅ Deploy Preview for cyf-module-project-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Hi,
I can see you've tried really really hard on this under diffcult circumstances but unfortunally there are some problems. Hopefully you'll be able to sort these, if you run into any issues at all, please feel free to reach out, and please don't be discouraged! I know it's hard, but it will get easier with time!
Few general points:
- If possible in future try to make small commits whenever you finish something - for instance when you get the image in the right place. This makes it easier to roll back your changes and it's a good habit.
- Are you still struggling with the image size?
- What are you struggling with Figma?
- your slack name is @nazanin Saedi, please don't put your email, might get spam
- For next time, try to follow the format the other students follow for the name of the pull request
| footer { | ||
| padding: 0 1.5rem; | ||
| max-width: 1200px; | ||
| margin: 0 auto; |
There was a problem hiding this comment.
In the picture, the image touches the side of the screen, so to achieve that, this should have no padding or max-width
| } | ||
|
|
||
| header { | ||
| margin-top: 30px; |
There was a problem hiding this comment.
We should be OK without this - it makes it so that there's quite a bit more whitespace on top of the nav than the picture asks for
| .nav-list { | ||
| margin-left: 15px; | ||
| padding: 0.rem 0; | ||
| font-family: 'sans-serif'; |
There was a problem hiding this comment.
If you look at the font in the nav bar on the header it looks quite diffrent from the font yours displays, so there's something wrong here.
The problem is this line 'sans-serif' doesn't work because you have put it in quotes, so the browser looks for a font called 'sans-serif' instead of understanding it as the name of a group of fonts.
To fix, simply remove this line. If this doesn't make sense let me know.
|
|
||
| .nav-item { | ||
| text-decoration: none; | ||
| color: rgb(153, 153, 153); |
There was a problem hiding this comment.
Got the gray colour right! The first item should be in bold though :)
| </div> | ||
| <div class="feature-content"> | ||
| <p class="feature-text"><span>“</span>Wherever I am, I just don't worry about my connection anymore!<span>”</span> </p> | ||
| <button class="get-karma">Get Karma today</button> |
There was a problem hiding this comment.
The image link is broken for me. Also need a bit of space between the button and edge of the box but this section is nearly there!
| <hr> | ||
| <p>Join Us On</p> | ||
| <div> | ||
| <a href="https://twitter.com/" target="_blank"><img class="footer-icon" src="img\twitter-icon.svg" alt="twitter-icon" /></a> |
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8"> |
There was a problem hiding this comment.
This page looks so good! Need to sort the image and the font-family issue I flagged earlier and it'll be perfect
| </div> | ||
| <div class="Address"> | ||
| <label for="Address">Address *</label> | ||
| <input id="Address" type="text" required /> |
There was a problem hiding this comment.
Good that you are using required here :)
| <label for="grey">Space grey</label> | ||
| </div> | ||
| <div class="place-order-content"> | ||
| <input id="agreement" type="checkbox" name="agreement" /> |
There was a problem hiding this comment.
I think this checkbox should be required too - add the required attribute
| <div class="city"> | ||
| <label for="city">City *</label> | ||
| <select id="city" name="city"> | ||
| <option value="initial" selected>Select your city...</option> |
There was a problem hiding this comment.
Good to use selected to select your default option by default
nazaninsaedi
changed the title
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy? It is not easy
What did you find hard? get the right size for images,Time management for me, it was difficult part for this project.
What do you still not understand? About Figma
Any other notes? No