Skip to content

NW6 | Nazanin-Saedi | HTML-CSS | Module-Project |Karma #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NW6 | Nazanin-Saedi | HTML-CSS | Module-Project |Karma #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion css/normalize.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* user zoom.
*/

html {
html {
font-family: sans-serif; /* 1 */
-ms-text-size-adjust: 100%; /* 2 */
-webkit-text-size-adjust: 100%; /* 2 */
Expand Down
232 changes: 230 additions & 2 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@

/* We are using the 'Roboto' font from Google. This has already been added to your HTML header */
/* We are using the 'Roboto' font from Google. This has already been added to your HTML header */

body {
font-family: 'Roboto', sans-serif;
Expand All @@ -15,5 +14,234 @@ body {
*
* - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex'
*/
header,
main,

footer {
padding: 0 1.5rem;
max-width: 1200px;
margin: 0 auto;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the picture, the image touches the side of the screen, so to achieve that, this should have no padding or max-width

}

header {
margin-top: 30px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be OK without this - it makes it so that there's quite a bit more whitespace on top of the nav than the picture asks for

}

.nav-menu {
display: flex;
list-style: none;
flex-direction: row;
justify-content: end;

}

.nav-list {
margin-left: 15px;
padding: 0.rem 0;
font-family: 'sans-serif';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the font in the nav bar on the header it looks quite diffrent from the font yours displays, so there's something wrong here.

The problem is this line 'sans-serif' doesn't work because you have put it in quotes, so the browser looks for a font called 'sans-serif' instead of understanding it as the name of a group of fonts.

To fix, simply remove this line. If this doesn't make sense let me know.

padding-bottom: 0px;
;

}

.nav-item {
text-decoration: none;
color: rgb(153, 153, 153);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the gray colour right! The first item should be in bold though :)

}

.nav-item:hover {
color: rgb(231, 51, 51);
}

.home-content {
margin-top: 70px;
}

.home {
background-image: url("../img/first-background.jpg");
background-size: cover;
height: 35rem;
display: flex;
justify-content: center;
text-align: center;
color: rgb(253, 250, 250);
}

button {
background-color: rgb(228, 97, 10);
color: rgb(255, 255, 255);
border: none;
border-radius: 5px;
padding: 15px;
padding-left: 30px;
padding-right: 30px;
}

.about {
margin-top: 4rem;
text-align: center;

}

.middle-article {
padding: 1rem 1;
}

.about-divs {
display: flex;
justify-content: space-around;
margin: 0 3rem;

}

.top-logo {
height: 30px;
width: 30px;
margin-right: 650px;


}

.middle-logo {
height: 100px;
width: auto;
}

.homepage-feature {
display: flex;
justify-content: center;
}

.homepage-feature img{
width: 100%;
}

.feature-content {
background-color:rgba(252, 179, 190, 0.235);
display: flex;
flex-direction: column;
align-items: center;
align-self: stretch;
text-align: center;
justify-content: center;
width: 100%;
margin-bottom: 4px;
}

.feature-content p {
display: block;
font-style: italic;
width: 50%;
margin: 2rem;
font-size: 2rem;
font-weight: 200;
}

.feature-content span {
color: rgb(228, 97, 10);
font-size: 3rem;
font-weight: 400;
}


.footer-icon {
width: 30px;
height: 30px;
}

footer {
text-align: center;
padding: 3rem;
}

.copyright {
color: rgb(145, 145, 145);
font-size: 0.8rem;
}

.h2-everyone {
margin-left: 50px;
font: caption;
font-size: 3rem;
color: rgb(29, 27, 26);
}

input[type=text],
select,
textarea {
width: 100%;
padding: 12px;
border: 2px solid rgb(169, 166, 166);
border-radius: 4px;
box-sizing: border-box;
margin-top: 10px;
margin-bottom: 20px;
resize: vertical;
}

.store-container img {
width: 100%;
height: auto;
}

.store-container {
display: grid;
grid-template-columns: 1fr 50%;
padding: 20px;
gap: 30px;
color: rgb(81, 81, 81);
}
.store-container h1, a {
color: rgb(228, 97, 10);
}
.store-container h1{
font: 400;
}

.colour {
padding-top: 40px;
padding-bottom: 40px;

}
input[type='radio'] {
accent-color: rgb(228, 97, 10);
}

.place-order-content button{
margin-top: 40px;
}



form {
display: grid;
grid-template-columns: repeat(6, 1fr);
grid-template-rows: 100px;
gap:10px;
}

.first-name {
grid-column: 1/4;
}

.last-name {
grid-column: 4/-1;
}

.Address {
grid-column: 1/-1;
}

.Address2 {
grid-column: 1/-1;
}

.city {
grid-column: 1/5;
}

.Postcode {
grid-column: 5/-1;
}


79 changes: 77 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,88 @@
<link href='https://fonts.googleapis.com/css?family=Roboto:400,500,300' rel='stylesheet' type='text/css'>
<link rel="stylesheet" href="css/normalize.css">
<link rel="stylesheet" href="css/style.css">
<link rel="shortcut icon" type="image/x-icon" href="favicon.ico">
<link rel="shortcuticon" type="image/x-icon" href="favicon.ico">
</head>
<body>

<!-- Add your HTML markup here -->
<!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc -->
<!-- All the images you need are in the 'img' folder -->
<header>
<div class="nav-menu">
<img class="top-logo" src="img/karma-logo.svg" alt="karma-logo" />
<nav >
<ul class="nav-menu">
<li class="nav-list">
<a href="#" class="nav-item">Meet Karma</a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be black and in bold

</li>
<li class="nav-list">
<a href="#" class="nav-item">How it works</a>
</li>
<li class="nav-list">
<a href="store.html" class="nav-item">Store</a>
</li>
<li class="nav-list">
<a href="#" class="nav-item">Blog</a>
</li>
<li class="nav-list">
<a href="#" class="nav-item">Help</a>
</li>
<li class="nav-list">
<a href="#" class="nav-item">Login</a>
</li>
</ul>
</nav>
</div>
</header>
<main>
<section class="home">
<div class="home-content">
<h2>Introducing Karma</h2>
<h3>Bring WiFI with you, everywhere you go.</h3>
<button class="learn">Learn More</button>
</div>
</section>

<section class="about">
<h2 class="h2-everyone">Everyone needs a little Karma.</h2>
<div class="about-divs">
<article class="middle-article">
<img class="middle-logo" src="img/icon-devices.svg" alt="icon-devices" />
<p>Internet for all devices</p>
</article>
<article class="middle-article">
<img class="middle-logo" src="img\icon-coffee.svg" alt="icon-coffee" />
<p>Boost your productivity</p>
</article>
<article class="middle-article">
<img class="middle-logo" src="img\icon-refill.svg" alt="icon-refill" />
<p>Pay as You go</p>
</article>
</div>
</h2>
</section>
<selection class="homepage-feature">
<div class="feature-image">
<img src="img\homepage-feature.png" alt="Homepage feature">
</div>
<div class="feature-content">
<p class="feature-text"><span>&ldquo;</span>Wherever I am, I just don't worry about my connection anymore!<span>&rdquo;</span> </p>
<button class="get-karma">Get Karma today</button>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image link is broken for me. Also need a bit of space between the button and edge of the box but this section is nearly there!

</div>
</selection>
</main>


<footer class="footer-content">
<hr>
<p>Join Us On</p>
<div>
<a href="https://twitter.com/" target="_blank"><img class="footer-icon" src="img\twitter-icon.svg" alt="twitter-icon" /></a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good section

<a href="https://facebook.com/" target="_blank"><img class="footer-icon" src="img\facebook-icon.svg" alt="facebook-icon" /></a>
<a href="https://instagram.com/" target="_blank"><img class="footer-icon" src="img\instagram-icon.svg" alt="instagram-icon" /></a>
</div>
<p class="copyright"><i>NazaninSaedi_2023</i> <hr>KarmaMobility, Inc.</p>
</footer>
</body>
</html>
</html>
Loading