[Jay-Mo-99] Week 6 #898
Open
[Jay-Mo-99] Week 6 #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaedie
reviewed
Jan 14, 2025
Comment on lines
+46
to
+49
| if (len(temp) == 0) : | ||
| return True | ||
| else: | ||
| return False |
There was a problem hiding this comment.
안녕하세요, @Jay-Mo-99 님,
개인 선호 차이인것 같습니다만, 아래와 같이 마무리해도 좋을것 같습니다. 😀
Suggested change
| if (len(temp) == 0) : | |
| return True | |
| else: | |
| return False | |
| return len(temp) == 0 |
또는
Suggested change
| if (len(temp) == 0) : | |
| return True | |
| else: | |
| return False | |
| return not temp |
There was a problem hiding this comment.
return에 바로 조건문을 입력하면 코드 수를 줄일수 있군요. if~else 구조 대신에 자주 사용해보도록 해봐야 겠어요. 피드백 감사합니다.
Chaedie
approved these changes
Jan 17, 2025
Comment on lines
+14
to
+19
| #Time Complexity: O(N) | ||
| #- while : s와 e가 만날때까지 최대 N번 반복된다. 각 반복에서의 연산들은 O(1)에 해당된다. -> O(N) | ||
|
|
||
|
|
||
| #Space Complexity: O(1) | ||
| #- s,e,max_area: 변수는 상수로 작용된다 -> O(1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.