-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ABI coder #3402
Open
petertonysmith94
wants to merge
24
commits into
ns/feat/abi-parser
Choose a base branch
from
ps/feat/abi-coder
base: ns/feat/abi-parser
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: ABI coder #3402
+9,214
−1,190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nedsalk
reviewed
Jan 8, 2025
@@ -47,7 +47,7 @@ export class Predicate< | |||
> extends Account { | |||
bytes: Uint8Array; | |||
predicateData: TData = [] as unknown as TData; | |||
interface: Interface; | |||
interface: AbiCoder; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
interface: AbiCoder; | |
abiCoder: AbiCoder; |
and all the other places where this renaming would break them.
nedsalk
reviewed
Jan 8, 2025
nedsalk
reviewed
Jan 8, 2025
packages/account/src/providers/transaction-response/getDecodedLogs.ts
Outdated
Show resolved
Hide resolved
nedsalk
reviewed
Jan 8, 2025
nedsalk
reviewed
Jan 8, 2025
@@ -54,7 +54,7 @@ export type DeployContractResult<TContract extends Contract = Contract> = { | |||
*/ | |||
export default class ContractFactory<TContract extends Contract = Contract> { | |||
bytecode: BytesLike; | |||
interface: Interface; | |||
interface: AbiCoder; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
interface: AbiCoder; | |
abiCoder: AbiCoder; |
…o ps/feat/abi-coder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaking Changes
Note
These will need to be combined into the final PR (#3085)
Interface
class has been removed in favour of theAbiCoder
.Interface.decodeFunctionResult
has moved to theAbiCoderFunction.decodeOutput
Interface.decodeLog
has moved to theAbiCoderLog.decode
Interface.encodeConfigurable
has moved to theAbiCoderConfigurable.encode
Interface.encodeType
andInterface.encodeType
has moved to theAbiCoderType
AbiEncoding
.INPUT_COIN_FIXED_SIZE
Encoding
from the@fuel-ts/crypto
package toBufferEncoding
.Checklist