Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ABI coder #3402
base: ns/feat/abi-parser
Are you sure you want to change the base?
feat: ABI coder #3402
Changes from 23 commits
0c4ed32
70a93d3
b210bec
7d437fe
bb4577e
601960f
c8aff8a
5020a8a
f86ec06
5102b63
63a4c58
b6b5c2e
b590e20
3a6b861
6862b09
9837e3c
de84957
e352512
0ad91bf
7162712
71ce5fa
b755501
53676b4
d30db1d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may need to be against the parser instead, but the flow from
ABISpecification
->ABI
-> coder/gen isn't completely clear to me. So I can still use the coder and gen without normalising the ABI?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be added to the parser documentation, but the general flow is:
External interface:
AbiSpecification
Internal interface:
AbiParser
acts as a translation layerAbi
formatcc @nedsalk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, please include in #3089
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the following comment, and will add to the PR description as items to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what documentation to add around this in #3089. The
AbiParser
itself works directly with the specification. What could perhaps be done is that theAbiCoder
can take both the specification andAbi
interface in its constructor, which'd clear up the possible confusion.