-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final version of updates for 6.5: grdimage, colorbar, grdmix #8251
Conversation
Moving parts over from old branch
Did not test OpenMP so missed some new variables.
This PR does now write a blank space after TRB, but places a there only if the images has transparency.
Especially in grdmix
Finalize the -Li|I positioning and frame dimensions and not break previous tests.
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added images
Modified imagesReport last updated at commit 03498f3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but need to update the copyright year to 2024 to make the "Code Validator" workflow pass.
Can we merge this? I need to trig a GMT build in the Julia system. |
Yep, doing it now. |
Master is now up to date with all those changes and copyright year is now 2024. |
OK, I'll build the Win installer tonight. |
Please also remember to do a Windows portable. |
Just fixed a few warnings and updated master. No big deal if you have started building yet. |
If you want one with 1 or 2 weeks old, I have it here. |
I built these 4 guys. Which one should we publish as 6.5?
|
You can choose what you think is useful for Win users and possibly Julia users. BTW, I fixed a half-dozen or so of warnings that were annoying me. Probably no need to rebuild your installers. |
This PR takes over the function of the previous PR (#8241) which now has been absorbed and modified into this cleaner PR. It also makes further adjustments to the placement and pale dimensions related to the enhanced -Li|I[gap] option in colorbar. I also have added a test for this whose plot looks like this:
You can see the older PR for various new test plots that documents the working of grdmix and grdimage. I get zero failures with this branch, running with or without OpenMP, Plesae make sure you change to theimg-layout branch, select static as active server (
export GMT_DATA_SERVER=static
) and run all tests. If you find any issues under Windows or Linux please let me know.The colorbar docs now states this:
I believe this is the last item to be merged into master before we release 6.5.