Fix standard manifest entries #284
Conversation
The loader aar contains the most recent standard entries. Previously this would forbid system-installed layers (such as the ultraleap layer) from being able to talk to their own services.
| android:required="true" | ||
| android:required="false" |
There was a problem hiding this comment.
Should we make this configurable? Because we don't know if the developer intends for the store to filter out devices without VR support
There was a problem hiding this comment.
So I am working on a writeup about this here, but basically, because as far as I know, <use-feature> only looks at the static configuration of the device, putting "true" here, in the best case scenario, limits things to only all-in-one devices and excludes phones using a plug-in viewer. (Worst case, this might actually filter out everything except the Daydream compatible devices still around out there.) I would rather leave this entry out entirely, since it appears to be ignored most of the time, than to include it as "required=true"
I have not tested this, but this corrects the manifest entries for the "Khronos" variant to match the entries added by the manifest in the loader AAR. This should increase compatibility of this build variant (as long as the activity is getting the right intent filter, which sadly can't be done this easily via merging manifest files)