Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix standard manifest entries #284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix standard manifest entries #284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0120a99
Update Khronos manifest to include the correct queries/intents.
rpavlik Mar 21, 2025
0c9be04
Fix the uses-feature block: we should not require the old vr.headtrac…
rpavlik Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions plugin/src/khronos/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<!-- Tell the system this app works in either 3dof or 6dof mode -->
<!-- Tell storefronts this app works in either 3dof or 6dof mode,
and do not filter out devices that did not ship with VR support. -->
<uses-feature
android:name="android.hardware.vr.headtracking"
android:required="true"
android:required="false"
Comment on lines -7 to +8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this configurable? Because we don't know if the developer intends for the store to filter out devices without VR support

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I am working on a writeup about this here, but basically, because as far as I know, <use-feature> only looks at the static configuration of the device, putting "true" here, in the best case scenario, limits things to only all-in-one devices and excludes phones using a plug-in viewer. (Worst case, this might actually filter out everything except the Daydream compatible devices still around out there.) I would rather leave this entry out entirely, since it appears to be ignored most of the time, than to include it as "required=true"

android:version="1"/>

<!-- Permissions needed by OpenXR -->
Expand All @@ -13,7 +14,10 @@

<queries>
<intent>
<action android:name="org.khronos.openxr.OpenXRRuntimeService"/>
<action android:name="org.khronos.openxr.OpenXRRuntimeService" />
</intent>
<intent>
<action android:name="org.khronos.openxr.OpenXRApiLayerService" />
</intent>
<provider android:authorities="org.khronos.openxr.runtime_broker;org.khronos.openxr.system_runtime_broker" />
</queries>
Expand Down