Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantms added #350

Merged
merged 5 commits into from
Oct 31, 2024
Merged

quantms added #350

merged 5 commits into from
Oct 31, 2024

Conversation

ypriverol
Copy link
Contributor

This PR add quantms to PSI MS as analysis software.

@ypriverol ypriverol requested a review from edeutsch October 30, 2024 14:37
Copy link
Contributor

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a definition line like this:

def: "Cloud-based pipeline for quantitative proteomics that enables the reanalysis of public proteomics data." [PMID:38965444]

Also, I don't know if the changes to validate-owl.yaml are appropriate. @mobiusklein ?

@edeutsch edeutsch requested a review from mobiusklein October 30, 2024 19:58
@ypriverol
Copy link
Contributor Author

@edeutsch the changes in the CI are correct. I just changed the previous URL from my private repo to the HUPO-PSI. I just change the definition.

@ypriverol
Copy link
Contributor Author

Related to issue #346

@ypriverol
Copy link
Contributor Author

@mobiusklein @edeutsch can we merge this one?

@mobiusklein
Copy link
Contributor

It just needs Eric to acknowledge his change request was satisfied.

Copy link
Contributor

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, thanks.

@mobiusklein mobiusklein added this pull request to the merge queue Oct 31, 2024
Merged via the queue into HUPO-PSI:master with commit 490ef9b Oct 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants