feat: ✨ enforce file deletion by MSPs #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
TDemeco
changed the base branch from
main
to
feat/file-system-benchmark-script
snowmead
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the logic to remove a MSP from the privileged providers list from the moment a user executes the
delete_fileextrinsic for a file key (without providing an inclusion proof) up until the MSP executes thepending_file_deletion_request_submit_proofextrinsic to provide an inclusion or non-inclusion proof for that file key.This way MSPs are incentivized to submit the required proof since otherwise they won't be able to charge any of their users.