Update global jdas enkf diag job with COMIN/COMOUT for COM prefix #2959

mingshichen-noaa · 2024-09-25T16:02:58Z

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global jdas enkf diagnostics job.

Refs #2451

Type of change

Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO

How has this been tested?

Clone and build on RDHPCS
Cycled tests on Hercules
Forecast-only tests on Hercules

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing tests pass with my changes
I have made corresponding changes to the documentation if necessary

KateFriedman-NOAA

Changes look ok for the most part but some COMOUTs needs to be changed to COMINs.

jobs/JGDAS_ENKF_DIAG

mingshichen-noaa · 2024-09-25T18:53:25Z

@KateFriedman-NOAA
Thank you very much for your comments. Based on your suggestions. I have changed "COMOUT_ATMOS_ANALYSIS_DET_PREV" into "COMIN_ATMOS_ANALYSIS_DET_PREV".

…_PREV

KateFriedman-NOAA

Requested updates alongside other updates look good, thanks @mingshichen-noaa !

emcbot · 2024-09-27T05:05:10Z

CI Update on Wcoss2 at 09/27/24 05:05:09 AM
============================================
Cloning and Building global-workflow PR: 2959
with PID: 52099 on host: clogin03

emcbot · 2024-09-27T05:49:44Z

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Fri Sep 27 05:11:33 UTC 2024 on clogin03
---------------------------------------------------
Build: Completed at 09/27/24 05:49:22 AM
Case setup: Completed for experiment C48_ATM_c55c8630
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_c55c8630
Case setup: Skipped for experiment C48_S2SWA_gefs_c55c8630
Case setup: Completed for experiment C48_S2SW_c55c8630
Case setup: Completed for experiment C96_atm3DVar_extended_c55c8630
Case setup: Skipped for experiment C96_atm3DVar_c55c8630
Case setup: Completed for experiment C96C48_hybatmaerosnowDA_c55c8630
Case setup: Completed for experiment C96C48_hybatmDA_c55c8630
Case setup: Completed for experiment C96C48_ufs_hybatmDA_c55c8630

emcbot · 2024-09-27T06:42:31Z

Experiment C96C48_hybatmDA_c55c8630 FAIL on Wcoss2 at 09/27/24 06:42:30 AM

Error logs:

/lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/RUNTESTS/COMROOT/C96C48_hybatmDA_c55c8630/logs/2021122100/gdasanaldiag.log

Follow link here to view the contents of the above file(s): (link)

WalterKolczynski-NOAA · 2024-09-28T07:03:16Z

JGDAS_ATMOS_ANALYSIS_DIAG also uses the exglobal_diag.sh script, so they have to be updated at the same time.

+ JGDAS_ATMOS_ANALYSIS_DIAG[30]: declare_from_tmpl -rx COM_ATMOS_ANALYSIS
+ bash_utils.sh[35]: [[ NO == \N\O ]]
+ bash_utils.sh[35]: set +x
declare_from_tmpl :: COM_ATMOS_ANALYSIS=/lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/RUNTESTS/COMROOT/C96C48_hybatmDA_c55c8630/gdas.20211221/00//analysis/atmos
+ JGDAS_ATMOS_ANALYSIS_DIAG[31]: mkdir -m 775 -p /lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/RUNTESTS/COMROOT/C96C48_hybatmDA_c55c8630/gdas.20211221/00//analysis/atmos
+ JGDAS_ATMOS_ANALYSIS_DIAG[35]: /lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/global-workflow/scripts/exglobal_diag.sh
Begin exglobal_diag.sh at Fri Sep 27 06:36:46 UTC 2024
++ exglobal_diag.sh[25]: pwd
+ exglobal_diag.sh[25]: pwd=/lfs/h2/emc/stmp/terry.mcguinness/RUNDIRS/C96C48_hybatmDA_c55c8630/gdas.2021122100/analdiag.246715
+ exglobal_diag.sh[28]: CDATE=2021122100
+ exglobal_diag.sh[29]: GDUMP=gdas
+ exglobal_diag.sh[32]: export 'CHGRP_CMD=chgrp rstprod'
+ exglobal_diag.sh[32]: CHGRP_CMD='chgrp rstprod'
+ exglobal_diag.sh[33]: export NCLEN=/lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/global-workflow/ush/getncdimlen
+ exglobal_diag.sh[33]: NCLEN=/lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/global-workflow/ush/getncdimlen
+ exglobal_diag.sh[34]: export CATEXEC=/apps/ops/prod/libs/intel/19.1.3.304/cray-mpich/8.1.4/ncdiag/1.0.0/bin/ncdiag_cat_serial.x
+ exglobal_diag.sh[34]: CATEXEC=/apps/ops/prod/libs/intel/19.1.3.304/cray-mpich/8.1.4/ncdiag/1.0.0/bin/ncdiag_cat_serial.x
+ exglobal_diag.sh[35]: COMPRESS=gzip
+ exglobal_diag.sh[36]: UNCOMPRESS=gunzip
+ exglobal_diag.sh[37]: APRUNCFP='mpiexec -l -np $ncmd --cpu-bind verbose,core cfp'
+ exglobal_diag.sh[40]: netcdf_diag=.true.
+ exglobal_diag.sh[41]: binary_diag=.false.
+ exglobal_diag.sh[44]: RUN=gdas
+ exglobal_diag.sh[45]: SENDECF=NO
+ exglobal_diag.sh[46]: SENDDBN=NO
+ exglobal_diag.sh[51]: export APREFIX=gdas.t00z.
+ exglobal_diag.sh[51]: APREFIX=gdas.t00z.
/lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/global-workflow/scripts/exglobal_diag.sh: line 52: COMOUT_ATMOS_ANALYSIS: unbound variable

mingshichen-noaa · 2024-10-07T20:30:07Z

@WalterKolczynski-NOAA:
Your comment: "JGDAS_ATMOS_ANALYSIS_DIAG also uses the exglobal_diag.sh script, so they have to be updated at the same time."
In fact, I have updated both GDAS_ATMOS_ANALYSIS_DIAG and exglobal_diag.sh script in this PR.
@RaghuReddy-NOAA::
Today you told me the jobs (JGDAS_ENKF_) are relevant each other, this means I should update all jobs (JGDAS_ENKF_) and associated bash and python scripts in one PR at the same time. Am I right?

The jobs (JGDAS_ENKF_*) include JGDAS_ENKF_DIAG, JGDAS_ENKF_ECEN , JGDAS_ENKF_POST, JGDAS_ENKF_SELECT_OBS, JGDAS_ENKF_SFC , JGDAS_ENKF_SNOW_RECENTER, JGDAS_ENKF_UPDATE

KateFriedman-NOAA

Approve pending successful completion of CI tests. Thanks @mingshichen-noaa !

emcbot · 2024-10-29T23:54:54Z

CI Passed on Hercules in Build# 2
Built and ran in directory /work2/noaa/global/CI/HERCULES/2959


Experiment C48_ATM_533b8f29 Completed 2 Cycles: *SUCCESS* at Tue Oct 29 16:58:36 CDT 2024
Experiment C96_S2SWA_gefs_replay_ics_533b8f29 Completed 1 Cycles: *SUCCESS* at Tue Oct 29 17:35:00 CDT 2024
Experiment C48_S2SW_533b8f29 Completed 2 Cycles: *SUCCESS* at Tue Oct 29 18:23:27 CDT 2024
Experiment C96C48_hybatmDA_533b8f29 Completed 3 Cycles: *SUCCESS* at Tue Oct 29 18:35:43 CDT 2024
Experiment C96_atm3DVar_533b8f29 Completed 3 Cycles: *SUCCESS* at Tue Oct 29 18:41:41 CDT 2024
Experiment C48_S2SWA_gefs_533b8f29 Completed 1 Cycles: *SUCCESS* at Tue Oct 29 18:54:44 CDT 2024

WalterKolczynski-NOAA · 2024-10-30T11:24:16Z

Running in /lfs/h2/emc/ptmp/walter.kolczynski/PR/PR_2959

emcbot · 2024-10-30T12:38:34Z

CI Passed on Hera in Build# 3
Built and ran in directory /scratch1/NCEPDEV/global/CI/2959


Experiment C96_S2SWA_gefs_replay_ics_533b8f29 Completed 1 Cycles: *SUCCESS* at Wed Oct 30 10:28:54 UTC 2024
Experiment C48_ATM_533b8f29 Completed 2 Cycles: *SUCCESS* at Wed Oct 30 10:35:00 UTC 2024
Experiment C48mx500_3DVarAOWCDA_533b8f29 Completed 2 Cycles: *SUCCESS* at Wed Oct 30 10:35:04 UTC 2024
Experiment C96_atm3DVar_533b8f29 Completed 3 Cycles: *SUCCESS* at Wed Oct 30 12:01:32 UTC 2024
Experiment C96C48_hybatmDA_533b8f29 Completed 3 Cycles: *SUCCESS* at Wed Oct 30 12:02:24 UTC 2024
Experiment C96C48_hybatmaerosnowDA_533b8f29 Completed 3 Cycles: *SUCCESS* at Wed Oct 30 12:02:35 UTC 2024
Experiment C48_S2SWA_gefs_533b8f29 Completed 1 Cycles: *SUCCESS* at Wed Oct 30 12:15:33 UTC 2024
Experiment C96C48_ufs_hybatmDA_533b8f29 Completed 3 Cycles: *SUCCESS* at Wed Oct 30 12:26:27 UTC 2024
Experiment C48_S2SW_533b8f29 Completed 2 Cycles: *SUCCESS* at Wed Oct 30 12:38:21 UTC 2024

mingshichen-noaa added 2 commits September 23, 2024 21:28

Changed COM_ into COMIN_ or COMOUT_

79d4199

changing COM_ATMOS into COMOUT_ATMOS

7ffb76b

mingshichen-noaa requested review from aerorahul, WalterKolczynski-NOAA and DavidHuber-NOAA September 25, 2024 16:03

aerorahul requested a review from KateFriedman-NOAA September 25, 2024 16:51

KateFriedman-NOAA requested changes Sep 25, 2024

View reviewed changes

jobs/JGDAS_ENKF_DIAG Outdated Show resolved Hide resolved

jobs/JGDAS_ENKF_DIAG Outdated Show resolved Hide resolved

jobs/JGDAS_ENKF_DIAG Outdated Show resolved Hide resolved

jobs/JGDAS_ENKF_DIAG Outdated Show resolved Hide resolved

mingshichen-noaa and others added 3 commits September 25, 2024 18:56

changing COMOUT_ATMOS_ANALYSIS_DET_PREV into COMIN_ATMOS_ANALYSIS_DET…

455f955

…_PREV

Merge branch 'develop' into feature/jdas_enkf_diag_com_in_out

a7df182

changing COMIN_STMOS_ANALYSIS into COMOUT

0ddb9fa

KateFriedman-NOAA previously approved these changes Sep 26, 2024

View reviewed changes

Merge branch 'develop' into feature/jdas_enkf_diag_com_in_out

c55c863

WalterKolczynski-NOAA previously approved these changes Sep 27, 2024

View reviewed changes

WalterKolczynski-NOAA added the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Sep 27, 2024

emcbot added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS and removed CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Sep 27, 2024

emcbot added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Sep 27, 2024

emcbot added CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Sep 27, 2024

WalterKolczynski-NOAA requested review from WalterKolczynski-NOAA and KateFriedman-NOAA September 28, 2024 07:03

mingshichen-noaa added 2 commits October 1, 2024 09:32

Merge branch 'develop' into feature/jdas_enkf_diag_com_in_out

9dab65d

Merge branch 'develop' into feature/jdas_enkf_diag_com_in_out

268190e

add _TMPL onto COM_ATMOS_ANALYSIS

533b8f2

mingshichen-noaa dismissed stale reviews from WalterKolczynski-NOAA and CoryMartin-NOAA via 533b8f2 October 29, 2024 19:45

DavidHuber-NOAA approved these changes Oct 29, 2024

View reviewed changes

DavidHuber-NOAA added CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules and removed CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels Oct 29, 2024

emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Oct 29, 2024

KateFriedman-NOAA approved these changes Oct 29, 2024

View reviewed changes

WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 30, 2024

WalterKolczynski-NOAA added the CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS label Oct 30, 2024

WalterKolczynski-NOAA added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Oct 30, 2024

emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Oct 30, 2024

Merge branch 'develop' into feature/jdas_enkf_diag_com_in_out

04bbf9b

WalterKolczynski-NOAA added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Oct 30, 2024

WalterKolczynski-NOAA merged commit f4e380a into NOAA-EMC:develop Oct 30, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update global jdas enkf diag job with COMIN/COMOUT for COM prefix #2959

Update global jdas enkf diag job with COMIN/COMOUT for COM prefix #2959

mingshichen-noaa commented Sep 25, 2024

KateFriedman-NOAA left a comment

mingshichen-noaa commented Sep 25, 2024

KateFriedman-NOAA left a comment

emcbot commented Sep 27, 2024

emcbot commented Sep 27, 2024

emcbot commented Sep 27, 2024

WalterKolczynski-NOAA commented Sep 28, 2024

mingshichen-noaa commented Oct 7, 2024

KateFriedman-NOAA left a comment

emcbot commented Oct 29, 2024

WalterKolczynski-NOAA commented Oct 30, 2024

emcbot commented Oct 30, 2024

Update global jdas enkf diag job with COMIN/COMOUT for COM prefix #2959

Update global jdas enkf diag job with COMIN/COMOUT for COM prefix #2959

Conversation

mingshichen-noaa commented Sep 25, 2024

Description

Type of change

Change characteristics

How has this been tested?

Checklist

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

mingshichen-noaa commented Sep 25, 2024

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

emcbot commented Sep 27, 2024

emcbot commented Sep 27, 2024

emcbot commented Sep 27, 2024

WalterKolczynski-NOAA commented Sep 28, 2024

mingshichen-noaa commented Oct 7, 2024

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

emcbot commented Oct 29, 2024

WalterKolczynski-NOAA commented Oct 30, 2024

emcbot commented Oct 30, 2024