fix(ui5-dynamic-page-title): conditionally apply ARIA attributes based on interactivity #12141
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d on interactivity Only apply button role and ARIA attributes when the title can actually toggle the header. When no header is present (non-interactive state), the title area should not have button semantics or related ARIA attributes. - Remove button role when title is not interactive - Remove aria-expanded when title is not interactive - Remove aria-describedby when title is not interactive This ensures screen readers don't announce toggle functionality when no header exists to toggle. Fixes: #12053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only apply button role and ARIA attributes when the title can actually toggle the header. When no header is present (non-interactive state), the title area should not have button semantics or related ARIA attributes.
buttonrole when title is not interactivearia-expandedwhen title is not interactivearia-describedbywhen title is not interactiveThis ensures screen readers don't announce toggle functionality when no header exists to toggle.
Fixes: #12053