Skip to content

fix(ui5-dynamic-page-title): conditionally apply ARIA attributes based on interactivity #12141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui5-dynamic-page-title): conditionally apply ARIA attributes based on interactivity #12141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/fiori/src/DynamicPageTitle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,16 @@ class DynamicPageTitle extends UI5Element {
return !this.snapped;
}

get _role() {
return this.interactive ? "button" : undefined;
}

get _ariaDescribedBy() {
return this.interactive ? `${this._id}-toggle-description` : undefined;
}

get _ariaDescribedbyText() {
return DynamicPageTitle.i18nBundle.getText(DYNAMIC_PAGE_ARIA_DESCR_TOGGLE_HEADER);
return this.interactive ? DynamicPageTitle.i18nBundle.getText(DYNAMIC_PAGE_ARIA_DESCR_TOGGLE_HEADER) : undefined;
}

get _ariaLabelledBy() {
Expand Down
4 changes: 2 additions & 2 deletions packages/fiori/src/DynamicPageTitleTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ export default function DynamicPageTitleTemplate(this: DynamicPageTitle) {
tabIndex={this._tabIndex}
onKeyDown={this._onkeydown}
onClick={this.onTitleClick}
role="button"
role={this._role}
aria-expanded={this.forAriaExpanded}
aria-labelledby={this._ariaLabelledBy}
aria-describedby={`${this._id}-toggle-description`}
aria-describedby={this._ariaDescribedBy}
></span>

{this.hasSnappedTitleOnMobile ?
Expand Down
Loading