Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language mappings from AniDB to TitleLanguage #1232

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix language mappings from AniDB to TitleLanguage #1232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
728ea08
fix: Resolve discrepancies with AniDB HTTP titles
Mik1ll Mar 5, 2025
7b91e50
Add AniDB albanian 2-character code
Mik1ll Mar 6, 2025
0abe6ed
Obsolete Bangladeshi enum value, add comments
Mik1ll Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Shoko.Plugin.Abstractions/DataModels/TitleLanguage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@

using System;

namespace Shoko.Plugin.Abstractions.DataModels;

/// <summary>
Expand Down Expand Up @@ -49,6 +51,7 @@ public enum TitleLanguage
/// <summary>
/// Bangladeshi.
/// </summary>
[Obsolete("Unused, check Bengali instead")]
Bangladeshi,

/// <summary>
Expand Down
33 changes: 17 additions & 16 deletions Shoko.Plugin.Abstractions/Extensions/LanguageExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System;
using System.Linq;
using Shoko.Plugin.Abstractions.DataModels;

namespace Shoko.Plugin.Abstractions.Extensions;
Expand Down Expand Up @@ -27,28 +26,30 @@ public static TitleLanguage GetTitleLanguage(this string lang)
"X-JAT" => TitleLanguage.Romaji,
"JA" or "JPN" => TitleLanguage.Japanese,
"AR" or "ARA" => TitleLanguage.Arabic,
"BD" or "BAN" => TitleLanguage.Bangladeshi,
// AniDB incorrectly maps BD to Bengali
"BD" or "BN" or "BAN" or "BGD" => TitleLanguage.Bengali,
"BG" or "BUL" => TitleLanguage.Bulgarian,
// CA isn't actually french canadian, but we have it mapped as such
// because anidb have it mapped as such.
"CA" or "FR-CA" => TitleLanguage.FrenchCanadian,
"CS" or "CES" or "CZ" => TitleLanguage.Czech,
"DA" or "DAN" or "DK" => TitleLanguage.Danish,
"DE" or "DEU" => TitleLanguage.German,
"EL" or "ELL" or "GR" => TitleLanguage.Greek,
"ES" or "SPA" => TitleLanguage.Spanish,
"EL" or "ELL" or "GR" or "GRC" => TitleLanguage.Greek,
"ES" or "SPA" or "ES-419" => TitleLanguage.Spanish,
"ET" or "EST" => TitleLanguage.Estonian,
"FI" or "FIN" => TitleLanguage.Finnish,
"FR" or "FRA" => TitleLanguage.French,
"GL" or "GLG" => TitleLanguage.Galician,
"GL" or "GLG" or "ES-GA" => TitleLanguage.Galician,
"HE" or "HEB" or "IL" => TitleLanguage.Hebrew,
"HU" or "HUN" => TitleLanguage.Hungarian,
"IT" or "ITA" => TitleLanguage.Italian,
"KO" or "KOR" => TitleLanguage.Korean,
"X-KOT" => TitleLanguage.KoreanTranscription,
"LT" or "LIT" => TitleLanguage.Lithuanian,
"MN" or "MON" => TitleLanguage.Mongolian,
"MS" or "MSA" or "MY" => TitleLanguage.Malaysian,
// AniDB incorrectly maps MY (Burmese) to Malaysian
"MS" or "MY" or "MSA" => TitleLanguage.Malaysian,
"NL" or "NLD" => TitleLanguage.Dutch,
"NO" or "NOR" => TitleLanguage.Norwegian,
"PL" or "POL" => TitleLanguage.Polish,
Expand All @@ -69,21 +70,21 @@ public static TitleLanguage GetTitleLanguage(this string lang)
"ZH-HANS" => TitleLanguage.ChineseSimplified,
"ZH-HANT" => TitleLanguage.ChineseTraditional,
"AF" or "AFR" => TitleLanguage.Afrikaans,
"SQ" or "SQI" => TitleLanguage.Albanian,
// AniDB incorrectly maps AL to Albanian
"SQ" or "AL" or "SQI" => TitleLanguage.Albanian,
"AM" or "AMH" => TitleLanguage.Amharic,
"HY" or "HYE" => TitleLanguage.Armenian,
"AZ" or "AZE" => TitleLanguage.Azerbaijani,
"EU" or "EUS" => TitleLanguage.Basque,
"EU" or "EUS" or "ES-PV" => TitleLanguage.Basque,
"BE" or "BEL" => TitleLanguage.Belarusian,
"BN" or "BEN" => TitleLanguage.Bengali,
"BS" or "BOS" => TitleLanguage.Bosnian,
"CA" or "CAT" => TitleLanguage.Catalan,
"CA" or "CAT" or "ES-CA" => TitleLanguage.Catalan,
"NY" or "NYA" => TitleLanguage.Chichewa,
"CO" or "COS" => TitleLanguage.Corsican,
"HR" or "HRV" => TitleLanguage.Croatian,
"DV" or "DIV" => TitleLanguage.Divehi,
"EO" or "EPO" => TitleLanguage.Esperanto,
"TL" or "FIL" => TitleLanguage.Filipino,
"TL" or "TGL" or "FIL" => TitleLanguage.Filipino,
"FJ" or "FIJ" => TitleLanguage.Fijian,
"KA" or "KAT" => TitleLanguage.Georgian,
"GU" or "GUJ" => TitleLanguage.Gujarati,
Expand All @@ -110,7 +111,8 @@ public static TitleLanguage GetTitleLanguage(this string lang)
"MT" or "MLT" => TitleLanguage.Maltese,
"MI" or "MRI" => TitleLanguage.Maori,
"MR" or "MAR" => TitleLanguage.Marathi,
"MY" or "MYA" => TitleLanguage.MyanmarBurmese,
// AniDB incorrectly maps MY to Malaysian, and uses BUR for Burmese instead
"MYA" or "BUR" => TitleLanguage.MyanmarBurmese,
"NE" or "NEP" => TitleLanguage.Nepali,
"OR" or "ORI" => TitleLanguage.Oriya,
"PS" or "PUS" => TitleLanguage.Pashto,
Expand Down Expand Up @@ -138,6 +140,7 @@ public static TitleLanguage GetTitleLanguage(this string lang)
"YO" or "YOR" => TitleLanguage.Yoruba,
"ZU" or "ZUL" => TitleLanguage.Zulu,
"UR" or "URD" => TitleLanguage.Urdu,
"X-THT" => TitleLanguage.ThaiTranscription,
"GREEK (ANCIENT)" => TitleLanguage.Greek,
"JAVANESE" or "MALAY" or "INDONESIAN" => TitleLanguage.Malaysian,
"PORTUGUESE (BRAZILIAN)" => TitleLanguage.BrazilianPortuguese,
Expand Down Expand Up @@ -175,7 +178,6 @@ public static string GetDescription(this TitleLanguage lang)
TitleLanguage.EnglishNewZealand => "English (New Zealand)",
TitleLanguage.Romaji => "Japanese (Romaji / Transcription)",
TitleLanguage.Japanese => "Japanese (Kanji)",
TitleLanguage.Bangladeshi => "Bangladesh",
TitleLanguage.FrenchCanadian => "Canadian-French",
TitleLanguage.BrazilianPortuguese => "Brazilian Portuguese",
TitleLanguage.Chinese => "Chinese (any)",
Expand All @@ -201,7 +203,6 @@ public static string GetString(this TitleLanguage lang)
TitleLanguage.Romaji => "x-jat",
TitleLanguage.Japanese => "ja",
TitleLanguage.Arabic => "ar",
TitleLanguage.Bangladeshi => "bd",
TitleLanguage.Bulgarian => "bg",
TitleLanguage.FrenchCanadian => "fr-CA",
TitleLanguage.Czech => "cz",
Expand All @@ -221,7 +222,7 @@ public static string GetString(this TitleLanguage lang)
TitleLanguage.Lithuanian => "lt",
TitleLanguage.Mongolian => "mn",
TitleLanguage.Malaysian => "ms",
TitleLanguage.Dutch => "ml",
TitleLanguage.Dutch => "nl",
TitleLanguage.Norwegian => "no",
TitleLanguage.Polish => "pl",
TitleLanguage.Portuguese => "pt",
Expand All @@ -233,7 +234,7 @@ public static string GetString(this TitleLanguage lang)
TitleLanguage.Serbian => "sr",
TitleLanguage.Swedish => "sv",
TitleLanguage.Thai => "th",
TitleLanguage.ThaiTranscription => "x-tha",
TitleLanguage.ThaiTranscription => "x-tht",
TitleLanguage.Turkish => "tr",
TitleLanguage.Ukrainian => "uk",
TitleLanguage.Vietnamese => "vi",
Expand Down