Fix bypassed tests by deduplicating test framework and use UnifySDK one #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
force-pushed
the
zpc/review/devel/main
branch
from
1a483fe to
6bd8559
Compare
1 task
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
This is not an atomic change, see next patch will pull upstream version Origin: SiliconLabsSoftware#70 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#6 Relate-to: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Not this is not latest version but it aligned to the version used at zwa, may unify-core align to it and synchronize all projects accordingly, or reconsider the architecture. Since UnifySDK also depends on CMock, indirect dep will be privileged, May those lines be removed in later cleanup changes. Origin: SiliconLabsSoftware#70 Bug-SiliconLabsSoftware: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…otocol-controller SiliconLabsSoftware#46 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 Docs should be regenerated from sources, but not stored along sources. More cleanup might be desirable for 1.7. Origin: SiliconLabsSoftware#70 Bug-SiliconLabs: SWPROT-8953 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…: Removed as not part of z-wave-protocol-controller SiliconLabsSoftware#60 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
force-pushed
the
zpc/review/devel/main
branch
from
6bd8559 to
05aee25
Compare
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…libs2/TestFramework/cmock: Removed as not part of z-wave-protocol-controller SiliconLabsSoftware#60 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…protocol-controller SiliconLabsSoftware#60 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…-wave-protocol-controller SiliconLabsSoftware#55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Relate-to: SiliconLabsSoftware#55 Bug: SiliconLabsSoftware#60 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…ntroller SiliconLabsSoftware#55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#55 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…ller SiliconLabsSoftware#55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#55 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
Origin: SiliconLabsSoftware#70 Bug-SiliconLabsSoftware: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…est SiliconLabsSoftware#46 Origin: SiliconLabsSoftware#70 Bug-SiliconLabsSoftware: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
Origin: SiliconLabsSoftware#70 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
changed the title
rzr
commented
Mar 19, 2025
| @@ -54,7 +54,7 @@ endif() | |||
| set(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} -g3") | |||
| if(NOT DEFINED SKIP_TESTING OR CMAKE_BUILD_TYPE STREQUAL Test) | |||
| enable_testing() | |||
| add_subdirectory(TestFramework) | |||
| # add_subdirectory(TestFramework) # TODO | |||
There was a problem hiding this comment.
let me isolate that change in a separate commit
silabs-aydogane
approved these changes
Mar 19, 2025
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…libs2/TestFramework/cmock: Removed as not part of z-wave-protocol-controller SiliconLabsSoftware#60 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
force-pushed
the
zpc/review/devel/main
branch
from
05aee25 to
66b107e
Compare
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…protocol-controller SiliconLabsSoftware#60 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…-wave-protocol-controller SiliconLabsSoftware#55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Relate-to: SiliconLabsSoftware#55 Bug: SiliconLabsSoftware#60 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…ntroller SiliconLabsSoftware#55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#55 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…ller SiliconLabsSoftware#55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#55 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
Origin: SiliconLabsSoftware#70 Bug-SiliconLabsSoftware: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…est SiliconLabsSoftware#46 Origin: SiliconLabsSoftware#70 Bug-SiliconLabsSoftware: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
Origin: SiliconLabsSoftware#70 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…5.3-g9d092898" SiliconLabsSoftware#60 This reverts commit 9865caa. Bug: SiliconLabsSoftware#46 Origin: SiliconLabsSoftware#36 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…Software#60 Patches from unify may land elsewhere Origin: SiliconLabsSoftware#36 Bug: SiliconLabsSoftware#55 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Origin: SiliconLabsSoftware#36 Bug: SiliconLabsSoftware#55 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…libs2/TestFramework/cmock: Removed as not part of z-wave-protocol-controller SiliconLabsSoftware#60 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…protocol-controller SiliconLabsSoftware#60 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…-wave-protocol-controller SiliconLabsSoftware#55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Relate-to: SiliconLabsSoftware#55 Bug: SiliconLabsSoftware#60 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…ntroller SiliconLabsSoftware#55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#55 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…ller SiliconLabsSoftware#55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: SiliconLabsSoftware#70 Bug: SiliconLabsSoftware#55 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Origin: SiliconLabsSoftware#70 Bug-SiliconLabsSoftware: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…est SiliconLabsSoftware#46 Origin: SiliconLabsSoftware#70 Bug-SiliconLabsSoftware: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Origin: SiliconLabsSoftware#70 Relate-to: SiliconLabsSoftware#46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
force-pushed
the
zpc/review/devel/main
branch
from
66b107e to
69ce234
Compare
silabs-peterb
approved these changes
Mar 19, 2025
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
Not this is not latest version but it aligned to the version used at zwa, may unify-core align to it and synchronize all projects accordingly, or reconsider the architecture. Since UnifySDK also depends on CMock, indirect dep will be privileged, May those lines be removed in later cleanup changes. Origin: #70 Bug-SiliconLabsSoftware: #60 Relate-to: #46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
…otocol-controller #46 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 Docs should be regenerated from sources, but not stored along sources. More cleanup might be desirable for 1.7. Origin: #70 Bug-SiliconLabs: SWPROT-8953 Relate-to: #46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
…: Removed as not part of z-wave-protocol-controller #60 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: #70 Bug: #46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
…libs2/TestFramework/cmock: Removed as not part of z-wave-protocol-controller #60 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: #70 Bug: #60 Relate-to: #46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
…protocol-controller #60 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: #70 Bug: #60 Relate-to: #46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
…-wave-protocol-controller #55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: #70 Relate-to: #55 Bug: #60 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
…ntroller #55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: #70 Bug: #55 Relate-to: #46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
…ller #55 This component is maintained at UnifySDK (v1.7+ aka core), This change deduplicate code, to ensure a single source of truth and enable a more sustainable developement model without overhead of monorepo. This change may be not atomic, but has been done in a way one component could be reverted if it justify a downstream (double) maintainance or experimental works. For the record this component was imported from: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.6.0 If this component should be re-introduced it would be preferable to consider the code where it is maintained eg: https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 (or later) Bug-SiliconLabs: SWPROT-8953 Origin: #70 Bug: #55 Relate-to: #46 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Depends on Unify Patches:
#47
For the record:
Checklist