SWPROT-8953: build: cmake: Use Upstream cmock from UnifySDK #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
commented
Mar 4, 2025
rzr
force-pushed
the
zpc/review/main
branch
2 times, most recently
from
17ada71 to
45827cf
Compare
rzr
force-pushed
the
zpc/review/main
branch
2 times, most recently
from
5728a87 to
6d825cf
Compare
1 task
rzr
changed the title
|
Next batch of changes will be: For the record those changes has been also tested on UnifySDK github ci: https://github.com/rzr/UnifySDK/actions/runs/13924711496/job/38966046097 100% tests passed, 0 tests failed out of 69 |
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…conLabsSoftware#60 This not an atomic change see next patch in PR Origin: SiliconLabsSoftware#47 Relate-to: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware#75 Relate-to: ThrowTheSwitch/CMock#503 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…ftware#60 This is not an atomic change, see next patch in PR Origin: SiliconLabsSoftware#47 Relate-to: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware#75 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
…e#77 For the record, I have enabled github action in UnifySDK repo, It is actually runing in forks eg: https://github.com/rzr/UnifySDK/tree/review/main https://github.com/rzr/UnifySDK/actions/runs/13765559449/job/38491058218 Tests are passing: But it fail later on packaging: I suspect the cause it all the assets in tree, this has to be cleaned up. This change prevent this problem, further cleaning may be considered. Origin: SiliconLabsSoftware#47 Relate-to: SiliconLabsSoftware#77 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#7 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
to rzr/z-wave-protocol-controller
that referenced
this pull request
Mar 19, 2025
For now public UnifySDK is patched, on longer term if needed a new repository for libunify could replace monorepo UnifySDK (The patch part should be then removed). Origin: SiliconLabsSoftware#47 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#6 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
This is not an atomic change, see next patch will pull upstream version Origin: SiliconLabsSoftware#47 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#6 Relate-to: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…conLabsSoftware#60 This not an atomic change see next patch in PR Origin: SiliconLabsSoftware#47 Relate-to: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware#75 Relate-to: ThrowTheSwitch/CMock#503 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…ftware#60 This is not an atomic change, see next patch in PR Origin: SiliconLabsSoftware#47 Relate-to: SiliconLabsSoftware#60 Relate-to: SiliconLabsSoftware#75 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…e#77 For the record, I have enabled github action in UnifySDK repo, It is actually runing in forks eg: https://github.com/rzr/UnifySDK/tree/review/main https://github.com/rzr/UnifySDK/actions/runs/13765559449/job/38491058218 Tests are passing: But it fail later on packaging: I suspect the cause it all the assets in tree, this has to be cleaned up. This change prevent this problem, further cleaning may be considered. Origin: SiliconLabsSoftware#47 Relate-to: SiliconLabsSoftware#77 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#7 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
For now public UnifySDK is patched, on longer term if needed a new repository for libunify could replace monorepo UnifySDK (The patch part should be then removed). Origin: SiliconLabsSoftware#47 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#6 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
silabs-aydogane
approved these changes
Mar 19, 2025
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
This is not an atomic change, see next patch will pull upstream version Origin: #47 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#6 Relate-to: #60 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
This not an atomic change see next patch in PR Origin: #47 Relate-to: #60 Relate-to: #75 Relate-to: ThrowTheSwitch/CMock#503 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
This is not an atomic change, see next patch in PR Origin: #47 Relate-to: #60 Relate-to: #75 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
that referenced
this pull request
Mar 19, 2025
For the record, I have enabled github action in UnifySDK repo, It is actually runing in forks eg: https://github.com/rzr/UnifySDK/tree/review/main https://github.com/rzr/UnifySDK/actions/runs/13765559449/job/38491058218 Tests are passing: But it fail later on packaging: I suspect the cause it all the assets in tree, this has to be cleaned up. This change prevent this problem, further cleaning may be considered. Origin: #47 Relate-to: #77 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#7 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not this is not latest version but it aligned to the version used at zwa, may unify-core align to it and synchronize all projects accordingly, or reconsider the archtecture.
Change
Checklist